Refactor new data model #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamader
requested review from
fzhao99,
m-goggins,
robertandremitchell and
DanPaseltiner
fzhao99
reviewed
Oct 22, 2024
fzhao99
reviewed
Oct 22, 2024
fzhao99
reviewed
Oct 22, 2024
fzhao99
reviewed
Oct 22, 2024
query-connector/src/app/query/components/selectQuery/queryHooks.ts
Outdated
Show resolved
Hide resolved
fzhao99
reviewed
Oct 22, 2024
|
(There actually were merge conflicts unfortunately, the refactor of the |
|
All comments addressed and filtering should now be working as intended |
|
Concept filtering now appropriately in place |
fzhao99
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This PR refactors our code base to leverage the new value set and concept data models that Marcelle developed as part of her spike work. Refactoring is done throughout the front and back end, fixing how we execute queries as well as display results.
Related Issue
Fixes https://app.zenhub.com/workspaces/skylight-dibbs-viper-6480ba23b5a07644e0e46d23/issues/gh/cdcgov/phdi/2789