query building write functionality pt 2

[fzhao99]

PULL REQUEST

Summary

Part two of the query building work that adds the actual editing.

Related Issue

Follow up to #256, fixes the following tickets

• https://linear.app/skylight-cdc/issue/QUE-116/implement-query-updating-on-condition-selection (fixes Implement query updating on condition selection #219)
• https://linear.app/skylight-cdc/issue/QUE-112/follow-up-for-design-review-and-clean-up-of-todo-items-on-valueset (fixes Follow up for design review and clean up of TODO items on ValueSet selection page #210)
• https://linear.app/skylight-cdc/issue/QUE-68/create-side-panel-interaction (fixes Create side panel interaction #141)

Additional Information

For design

Since we haven't implemented the search on the drawers, went ahead and turned those off for the connectathon. Will follow up on these in upcoming tickets

• Check the alignment of the conditions rail / drawer
  
  

• Added a confirmation toast on the save query and the drawer updating. Let us know if we want to change any of this!
  

Screen.Recording.2025-01-09.at.4.22.36.PM.mov

Checklist

• Descriptive Pull Request title
• Link to relevant issues
• Provide necessary context for design reviewers
• Update documentation

[linear]

QUE-33 Build out query building write functionality

[robertandremitchell]

Looks fantastic! a few notes, none of which I think are blocking. Happy to make follow-up tickets.

• Do we want some kind of save warning modal for going back a page when changes have been made? The sequencing for the save changes seems kinda weird to me, like it should take you back to the My Queries page to see/confirm, without having to click the two back buttons to retrieve the ID / review.

Screen.Recording.2025-01-10.at.9.23.21.AM.mov

• Did we get rid of the toast for adding a condition? I think that's fine, but I wonder if we want any kind of warning modal or other confirmation for deletion of a condition?
• I think here we would want the alt text to be the names of the conditions?

* The click on the accordion seems like it should not trigger deselecting all? I don't know best practices for this, but I would think we want clicking on the name of the valueSetType to only open/close the accordion.

Screen.Recording.2025-01-10.at.9.20.02.AM.mov

[fzhao99]

Went ahead and added the save redirect, condition include modal, and alt text! Great suggestions / catches

Screen.Recording.2025-01-10.at.11.02.56.AM.mov

• The click on the accordion seems like it should not trigger deselecting all? I don't know best practices for this, but I would think we want clicking on the name of the valueSetType to only open/close the accordion.

For this one, the label on a checkbox is usually included in the checkbox target for accessibility reasons. For motor-impaired users, having the larger click target makes the checkbox more interactible.

[katyasoup]

Seeing some weird behavior on certain ValueSets where the select/deselect all checkbox isn't working for value sets in a single template:

• note that the expected checkbox does not change to the [-] state when some codes are selected;
• at the very end the labs checkbox changes to [-] when toggling the set of condition codes
• the count is off ("5 codes added/removed" but it should be the three shown in the drawer)

Screen.Recording.2025-01-10.at.12.21.42.mov

[katyasoup]

more of a nit, but can we wrap (or otherwise handle) these long IDs so the right-side data isn't getting pushed over?

[katyasoup]

Seeing some weird behavior on certain ValueSets

I thought it might be because one of these conditions happened to belong to more than one template (Kawasaki's disease ICD10 Value Set appears in two), but the checkbox status is behaving independently as I'd expect between the two:

Screen.Recording.2025-01-10.at.12.38.01.mov

[katyasoup]

approving since @fzhao99 and I weren't able to reliably reproduce the checkbox bug

[fzhao99]

Seeing some weird behavior on certain ValueSets where the select/deselect all checkbox isn't working for value sets in a single template:

• note that the expected checkbox does not change to the [-] state when some codes are selected;
• at the very end the labs checkbox changes to [-] when toggling the set of condition codes
• the count is off ("5 codes added/removed" but it should be the three shown in the drawer)

Screen.Recording.2025-01-10.at.12.21.42.mov

katie and I tried bug hunting this and couldn't find a reliable way to repro. since we want to have this for the connectathon, going to merge and keep an eye out for the bug in our testing sessions