Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust self-signed certificates when using the eHX FHIR proxy #18

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

DanPaseltiner
Copy link
Collaborator

PULL REQUEST

Summary

The eHealth Exchange FHIR proxy currently uses a self-signed TLS certificate. Since we are no longer trusting self-signed certs globally in the application to restore our connection with eHX we need to configure trust them when making requests to eHX

Related Issue

Fixes #2578

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review

  • ex: “Check out the whitespace on the page, as well as the dropdowns in the form. Here is the corresponding Figma link. You can ignore everything else. Also, the button at the bottom doesn’t work now”

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. seemed a tad slow when I tested with Cucumber Hill but otherwise worked

@DanPaseltiner
Copy link
Collaborator Author

looks good. seemed a tad slow when I tested with Cucumber Hill but otherwise worked

Using eHX adds more hops to responses are slower and if you used the Cerner server that one tends to be slower still because there is an auth process that happens as well.

@DanPaseltiner DanPaseltiner merged commit eccdaed into main Oct 15, 2024
4 checks passed
@fzhao99 fzhao99 deleted the allow-ehx-self-signed-cert branch October 31, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants