Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condition template selection page #119

Merged
merged 24 commits into from
Nov 8, 2024

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Nov 5, 2024

PULL REQUEST

Summary

Part two that builds the actual page.

For now, I've put this page at /queryBuilding/buildFromTemplate, but worth a larger convo around when we use the Next router for URL-based rendering and when we handle things in a more SPA fashion like we do with the query search flow.

For design

  • Page available at queryBuilding/buildFromTemplate. The page is read-only for now (ie the "create query" button doesn't do / redirect to anything and the query name field also doesn't do anything). "Writing" this info and updating the relevant pages are forthcoming
  • Check that spacing, font, colors are aligned with design
    • Recognize the two columns are unbalanced in terms of how many conditions are in the two columns, but balancing them is an instance of the knapsack problem. Basically, the algorithm to do is really complicated, which felt like overkill for the context.
    • Can revisit this in a followup PR though! Might be fun to dust off my actual computer science degree :)
  • Check the interactivity for the search field
  • The "Create Query" button is disabled for now until at least one template is selected, but will leave us to update the interaction based on this conversation. in another PR

Related Issue

Fixes #75

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Update documentation

Copy link

linear bot commented Nov 5, 2024

@fzhao99 fzhao99 force-pushed the bob/que-32-build-in-condition-template-selection-page branch from 5e3405c to 0d11d5e Compare November 6, 2024 15:05
@fzhao99 fzhao99 changed the title Bob/que 32 build in condition template selection page condition template selection page Nov 6, 2024
@fzhao99 fzhao99 force-pushed the bob/que-32-build-in-condition-template-selection-page branch from 727fab4 to c7635bb Compare November 6, 2024 18:40
@fzhao99 fzhao99 changed the base branch from main to bob/que-32-build-in-condition-template-selection-page-pt-1 November 6, 2024 18:41
@fzhao99 fzhao99 requested a review from katyasoup November 6, 2024 18:41
@fzhao99 fzhao99 force-pushed the bob/que-32-build-in-condition-template-selection-page branch from 3c1d6fb to ce4a3ab Compare November 7, 2024 16:37
Base automatically changed from bob/que-32-build-in-condition-template-selection-page-pt-1 to main November 7, 2024 17:08
@fzhao99 fzhao99 marked this pull request as ready for review November 7, 2024 17:33
@fzhao99 fzhao99 requested review from mikang and nickclyde November 7, 2024 17:33
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. only minor quibbles

  • at least on the figma Back to My Queries isn't underlined
  • there isn't the Demo alert at the top of the page. that might be just because the page is not connected to stuff currently, as i write this..carry on!

@fzhao99
Copy link
Collaborator Author

fzhao99 commented Nov 8, 2024

  • at least on the figma Back to My Queries isn't underlined

@mikang it looks like the other backlinks in the query customization flow are underlined, so let us know if this one should be too.

@mikang
Copy link
Collaborator

mikang commented Nov 8, 2024

The search is beautiful @fzhao99 — I think it deserves its own GH comment

@mikang
Copy link
Collaborator

mikang commented Nov 8, 2024

@mikang
Copy link
Collaborator

mikang commented Nov 8, 2024

looks good to me. only minor quibbles

  • at least on the figma Back to My Queries isn't underlined
  • there isn't the Demo alert at the top of the page. that might be just because the page is not connected to stuff currently, as i write this..carry on!

hmm true about the underline. I didn't notice that on the other pages. Is it possible to remove the underline from all backlinks that have an arrow? The underline is good for accessibility to show that it's clickable, but considering there is an arrow, I'm not concerned about it not seeming clickable

@fzhao99 fzhao99 merged commit c10bcfe into main Nov 8, 2024
5 checks passed
@fzhao99 fzhao99 deleted the bob/que-32-build-in-condition-template-selection-page branch November 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build in condition template selection page
3 participants