-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
condition template selection page #119
condition template selection page #119
Conversation
5e3405c
to
0d11d5e
Compare
…t-1' of https://github.com/CDCgov/dibbs-query-connector into bob/que-32-build-in-condition-template-selection-page-pt-1
727fab4
to
c7635bb
Compare
3c1d6fb
to
ce4a3ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. only minor quibbles
- at least on the figma Back to My Queries isn't underlined
- there isn't the Demo alert at the top of the page. that might be just because the page is not connected to stuff currently, as i write this..carry on!
https://github.com/CDCgov/dibbs-query-connector into bob/que-32-build-in-condition-template-selection-page
@mikang it looks like the other backlinks in the query customization flow are underlined, so let us know if this one should be too. |
The search is beautiful @fzhao99 — I think it deserves its own GH comment |
hmm true about the underline. I didn't notice that on the other pages. Is it possible to remove the underline from all backlinks that have an arrow? The underline is good for accessibility to show that it's clickable, but considering there is an arrow, I'm not concerned about it not seeming clickable |
PULL REQUEST
Summary
Part two that builds the actual page.
For now, I've put this page at
/queryBuilding/buildFromTemplate
, but worth a larger convo around when we use the Next router for URL-based rendering and when we handle things in a more SPA fashion like we do with the query search flow.For design
queryBuilding/buildFromTemplate
. The page is read-only for now (ie the "create query" button doesn't do / redirect to anything and the query name field also doesn't do anything). "Writing" this info and updating the relevant pages are forthcomingRelated Issue
Fixes #75
Checklist