-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DQC main page README #114
Merged
robertandremitchell
merged 12 commits into
main
from
robertamitchell/que-15-update-dibbs-query-connector-readme
Nov 5, 2024
Merged
Update DQC main page README #114
robertandremitchell
merged 12 commits into
main
from
robertamitchell/que-15-update-dibbs-query-connector-readme
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertandremitchell
requested review from
bamader,
nickclyde,
katyasoup,
fzhao99,
m-goggins and
DanPaseltiner
November 5, 2024 13:51
m-goggins
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! I added a bit more language to define what it is and what the problem scope is. It doesn't have to be for this PR, but I do think we should pull Matt in for a review of this language.
Co-authored-by: Marcelle <[email protected]>
Co-authored-by: Marcelle <[email protected]>
Co-authored-by: Marcelle <[email protected]>
robertandremitchell
deleted the
robertamitchell/que-15-update-dibbs-query-connector-readme
branch
November 5, 2024 21:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This update the main README on the main page of the repo. It is not nearly as comprehensive as the PHDI main page README, but I felt the main things we wanted to keep were the overview/history of DIBBs/PHDI work, an overview of the repo code, and some kind of link to demo/examples people could use.
Definitely will need a much more comprehensive workflow once we have a
/redoc
equivalent, a separate demo workflow, and the like.I don't know if we want to take the time for Michelle, Laura, Ryan, and/or Matt to do a fuller review / update of the copy, or if that show take a backseat for now in favor of ensuring the design overall is in a good place.
Related Issue
Fixes #54
Additional Information
Anything else the review team should know?
Checklist