Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating condition category mapping work in database-services #112

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

robertandremitchell
Copy link
Collaborator

@robertandremitchell robertandremitchell commented Nov 4, 2024

PULL REQUEST

Summary

Per conversation in 11/4 call, we do not want to use an API call for conditions data. To do this instead, I have opted ot try to use one call in the database-services.ts to ensure we have the main JSONs we should need:

  1. a JSON that is grouped by category for ease of displaying the name of each condition. The ID is included so that in the search function that will be on the page, someone could also search by ID.
  2. a JSON of id and name. This is done because in order to make selections, we will need the IDs to look up and pull the valueset/concepts for display on the next page.

We could plausibly do this one with just the first JSON if we want to have additional transformation work, but because each of these should be negligible in size, it seems better to just do the work here?

Related Issue

Fixes https://linear.app/skylight-cdc/issue/QUE-26/expose-category-information-to-the-frontend.

Additional Information

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Update documentation

Copy link

linear bot commented Nov 4, 2024

Copy link
Collaborator

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@robertandremitchell robertandremitchell merged commit c02c72e into main Nov 4, 2024
5 checks passed
@robertandremitchell robertandremitchell deleted the rob/remove-api-call-for-conditions-data branch November 4, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants