Create json for custom valuesets using internal valueset schema #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
m-goggins
changed the title
…into marcelle/98-create-json-for-custom-valuesets-using-internal-valueset-schema
m-goggins
requested review from
nickclyde,
katyasoup,
fzhao99,
robertandremitchell,
bamader and
DanPaseltiner
robertandremitchell
approved these changes
Nov 1, 2024
fzhao99
approved these changes
Nov 1, 2024
m-goggins
deleted the
marcelle/98-create-json-for-custom-valuesets-using-internal-valueset-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This ticket adds the custom valuesets we've developed thus far as a JSON object following the
ValueSetconvention we came up with. This will allow us to insert the custom valuesets when creating the database. There's a follow up ticket to actually do the insertions.Related Issue
Fixes #98
Additional Information
Note: we do not expect to add any more custom valuesets to this file as we expect users to add their own once we have the query creation work completed.
Checklist