ALB as internal/internet facing 🥅 #12
Conversation
alismx
changed the title
alismx
changed the title
@shanice-skylight No output. If you'd like, we can pair tomorrow and we can go over the requirements to run the terraform. A tfvars file is needed. |
| @@ -31,6 +31,7 @@ | |||
|
|
|||
| | Name | Description | Type | Default | Required | | |||
| |------|-------------|------|---------|:--------:| | |||
| | <a name="input_alb_internal"></a> [alb\_internal](#input\_alb\_internal) | Whether the ALB is public or private | `bool` | `true` | no | | |||
There was a problem hiding this comment.
Non-blocking, for your consideration: the concepts of "internal" and "private" may be disjoint to certain end users or jurisdictions. You may want to consider buffing the description to include something like, "Whether the ALB is public (intended for external access) or private (only intended to be accessed within your AWS private cloud)."
There was a problem hiding this comment.
I'll include these clarifications on the next PR!
| @@ -56,6 +56,7 @@ No modules. | |||
|
|
|||
| | Name | Description | Type | Default | Required | | |||
| |------|-------------|------|---------|:--------:| | |||
| | <a name="input_alb_internal"></a> [alb\_internal](#input\_alb\_internal) | Flag to determine if the ALB is public | `bool` | `true` | no | | |||
There was a problem hiding this comment.
See above comment regarding the concepts of private vs internal.
| @@ -1,3 +1,8 @@ | |||
| variable "alb_internal" { | |||
| type = bool | |||
| description = "Flag to determine if the ALB is public" | |||
There was a problem hiding this comment.
See above comment regarding the concepts of private vs internal.
DEVOPS PULL REQUEST
Related Issue
Changes Proposed
Additional Information