Added mutation services for subscrib/unsubscribe to active/passive no… #190
Conversation
…tifications ktor routes
|
...graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/response/Response.kt
Show resolved
Hide resolved
| * @param dataStreamRoute String | ||
| * @param jurisdiction String | ||
| * @param daysToRun List<String> | ||
| * @param deliveryReference String |
There was a problem hiding this comment.
What is the delivery reference? We may want to give a description here or rename. I think the original intent of the delivery reference was to be a reusable delivery reference. In other words, you setup a delivery for emails to a list of people and could reuse this across different subscriptions. If we haven't done that and this is just the delivery type or something else, we should explain that here and/or rename the variable.
| * @param deliveryReference String | ||
| */ | ||
|
|
||
| @GraphQLDescription("Subscribe Deadline Check") |
There was a problem hiding this comment.
Can we give a longer description for these? This is what is shown in the graphql introspection documentation and you can't really figure out what this is or how it works from this description.
|
|
||
| @GraphQLDescription("UnSubscribe Deadline Check") | ||
| @Suppress("unused") | ||
| fun unsubscribeUploadErrorsNotification( |
There was a problem hiding this comment.
Are we able to consolidate on one unsubscribe like we have in the design? I thought we'd cover that as part of this work. Similarly, I thought we were going to consolidate the subscribe mutations as well per the new lucidchart design.
@mkrystof - This is promotion of the PoC mutations to graphQL mutations project, These mutations will change eventually to 3-4 generic ones. At this point, these changes are just to reflect the PoC changes done on notifications ktor, so that we have something to show for until the actual notifications ktor is in place and its corresponding graphQl mutations are in place