Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DASB-667-Add ability to select message service in report sink service: AWS SNS/SQS #188

Merged
merged 13 commits into from
Sep 12, 2024

Conversation

TeaSmith7
Copy link
Collaborator

This PR implements the AWS SNS/SQS plugin and includes several key updates:

  1. Setup and configuration for AWS SQS to listen to messages from the configured SQS service.
  2. Improved health checks for all supported services and added health check for AWS SNS/SQS.
  3. Updated the README.md

…sages() function; begin README.md update with AWS SQS configuration details
…erties

- Renamed ServiceBusMessage.kt to MessageBase.kt for broader applicability across messaging systems.
- Updated codebase references to reflect these changes.
- Added missing properties to the header comment in CreateReportMessage.kt.
… bus library

log unsupported message system from config and added health check for it
Removed com.microsoft.azure:azure-servicebus:3.6.7 and replaced it with com.azure:azure-messaging-servicebus:7.15.0.
Updated Healthcheck.kt to use serviceBusException from the com.azure:azure-messaging-servicebus:7.15.0
Added com.sun.activation:javax.activation:1.2.0 to support MimeType checking.
Updated some library versions to address vulnerabilities.
Added while loop back to AWSSQS.kt
Replaced runBlocking with CoroutineScope in AWS SQS module to ensure non-blocking execution, which was blocking health endpoint to fail for AWS SQS.
Refactored HealthCheck.kt by adding private functions to check and update health status for all supported services
Added compileHealthChecks() to compile and return health status of all services in a single response.
Copy link

sonarcloud bot commented Sep 12, 2024

Copy link
Collaborator

@mkrystof mkrystof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TeaSmith7 TeaSmith7 merged commit 3dea2c9 into develop Sep 12, 2024
1 of 2 checks passed
@TeaSmith7 TeaSmith7 deleted the DASB-667 branch September 12, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants