generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create report mutation #186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the items in the Page after the page data is returned.
mkrystof
previously requested changes
Sep 12, 2024
...ql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/models/reports/ReportInputSchema.kt
Outdated
Show resolved
Hide resolved
...ql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/models/reports/ReportInputSchema.kt
Outdated
Show resolved
Hide resolved
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
…(JSON, APPLICATION/JSON, BASE64), upload actions(CREATE, REPLACE)
manu-govind
reviewed
Sep 23, 2024
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
...hql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutationService.kt
Outdated
Show resolved
Hide resolved
...ql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/models/reports/ReportInputSchema.kt
Outdated
Show resolved
Hide resolved
mtammineni
requested review from
manu-govind and
mkrystof
and removed request for
mkrystof
September 23, 2024 15:46
Quality Gate passedIssues Measures |
manu-govind
approved these changes
Sep 24, 2024
} | ||
} | ||
else -> { | ||
throw ContentException("Unsupported content type: $contentType") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed here
...us-graphql-ktor/src/main/kotlin/gov/cdc/ocio/processingstatusapi/mutations/ReportMutation.kt
Outdated
Show resolved
Hide resolved
mtammineni
requested review from
mkrystof and
manu-govind
and removed request for
mkrystof and
manu-govind
September 24, 2024 18:43
mtammineni
dismissed
mkrystof’s stale review
September 24, 2024 19:05
Some of the files are outdated. The review is done by Manu after refactoring.
mkrystof
approved these changes
Sep 24, 2024
Create/ Replace Report feature added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.