Bug data producer id missing in reports #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mkrystof
requested changes
Aug 29, 2024
| @@ -62,6 +62,17 @@ dependencies { | |||
| implementation "com.expediagroup:graphql-kotlin-schema-generator:6.0.0" | |||
| implementation "io.ktor:ktor-server-netty:2.1.0" | |||
| implementation "io.ktor:ktor-client-content-negotiation:2.1.0" | |||
|
|
|||
| implementation("org.jeasy:easy-rules-core:4.1.0") | |||
There was a problem hiding this comment.
I think this bug fix is mixed up with the easy-rules stuff. Do you need to include both in this PR?
There was a problem hiding this comment.
Not sure how it got in there. Will remove it.
| this.messageMetadata = messageMetadata | ||
| this.stageInfo= stageInfo | ||
| this.tags = tags | ||
| this.data = data | ||
| this.jurisdiction = jurisdiction |
There was a problem hiding this comment.
The jurisdiction should not be removed.
There was a problem hiding this comment.
Same. Removed the duplicated one. Somehow both were added twice.
| @@ -239,13 +248,12 @@ class ReportManager: KoinComponent { | |||
| this.dataStreamRoute = dataStreamRoute | |||
| this.dexIngestDateTime = dexIngestDateTime | |||
| this.jurisdiction = jurisdiction | |||
| this.senderId = senderId | |||
There was a problem hiding this comment.
The senderId should not be removed.
There was a problem hiding this comment.
I removed the duplicated one. It was repeated in the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue of Reports and RDLQ not using data_producer_id