-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 559: Diagnostic analysis over all inference runs #560
Conversation
Try this Pull Request!Open Julia and type: import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="559-report-for-mcmc-quality", subdir="EpiAware")
using EpiAware |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 60 60
Lines 863 863
=======================================
Hits 785 785
Misses 78 78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. It would be nice to add a test to show the core mcmc diagnostic functions works in and of itself. I think it would also be good for the future to add some convergence summaries beyond the thresholds (I think having a figure on this was planned in the analysis plan but it can be a follow up issue/PR as its not on the critical path for this feature
Also removed unnecessary call to `fetch`
Adds more stats and a unit test
I think this is ready for rereview: less DRY, unit test for the mcmc_convergence and more stats. |
I've gone for:
NB r hat is presented as abs diff from 1.0 e.g a mean of 0.001 is good not bad! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks good to me!
This PR closes #559
This PR adds an analysis function which returns details around the MCMC convergence:
The PR also adds a script to run this across all inferences, and adds recording successes to the success/fail analysis.