Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 532: Change deps and remove Dagger for pipeline #534

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

This PR closes #532 .

The way in which I've addressed problems described in #532 around using RCall and Dagger in the pipeline execution is to:

  1. Move the usage of RCall into an extension of EpiAwarePipeline. This means we can still call to scoringutils in post-processing but it doesn't need to installed for a pipeline main inference compute.
  2. Removed Dagger and replace with pmap. This is a bit disappointing but it works fine for this problem.

@SamuelBrand1 SamuelBrand1 linked an issue Dec 5, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Try this Pull Request!

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="532-reduce-pipeline-deps-and-simplify-pipeline-compute", subdir="EpiAware")
using EpiAware

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice good solution. A shame about Dagger

@seabbs seabbs enabled auto-merge December 5, 2024 15:02
@SamuelBrand1
Copy link
Collaborator Author

Nice good solution. A shame about Dagger

Agreed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (ae73647) to head (a308479).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files          57       57           
  Lines         825      825           
=======================================
  Hits          747      747           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 5274760 Dec 5, 2024
11 checks passed
@seabbs seabbs deleted the 532-reduce-pipeline-deps-and-simplify-pipeline-compute branch December 5, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce pipeline deps and simplify pipeline compute
3 participants