-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 532: Change deps and remove Dagger for pipeline #534
Issue 532: Change deps and remove Dagger for pipeline #534
Conversation
Try this Pull Request!Open Julia and type: import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="532-reduce-pipeline-deps-and-simplify-pipeline-compute", subdir="EpiAware")
using EpiAware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice good solution. A shame about Dagger
Agreed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage 90.54% 90.54%
=======================================
Files 57 57
Lines 825 825
=======================================
Hits 747 747
Misses 78 78 ☔ View full report in Codecov by Sentry. |
This PR closes #532 .
The way in which I've addressed problems described in #532 around using
RCall
andDagger
in the pipeline execution is to:RCall
into an extension ofEpiAwarePipeline
. This means we can still call toscoringutils
in post-processing but it doesn't need to installed for a pipeline main inference compute.Dagger
and replace withpmap
. This is a bit disappointing but it works fine for this problem.