-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialisation for epidemic inference #42
Initialisation for epidemic inference #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice. I like the reorg. Some general comments about naming, docs etc which feel a little messy here.
I really like the use of
In terms of the renaming etc I think I would again suggest we move many of these comments to issues so we can keep up the velocity. The only change I would really like to see here is an explicit test of the approximation approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Making an issue for internal functions now.
This PR is for creating an appropriate initialisation for inference. In practice, this applies to the renewal model approach encapsulated by the
Renewal
model.Major changes
init
kw value and this can have its own priors e.g. here:Rt-without-renewal/EpiAware/src/latent-processes.jl
Lines 17 to 24 in dece834
AbstractEpiModel
is now fixed as defining the latent process -> infections transformation. Before it defined an updating function to be used byscan
; however that was not the natural approach in (say) direct infection modelling. Instances ofRenewal
model now usescan
under the hood. eg here:Rt-without-renewal/EpiAware/src/models.jl
Lines 15 to 19 in dece834
Renewal
here.Renewal
initialisation is done by treatinginit
as defining a time zero incidence. The pre-time zero incidence is backwards exponential with the exponential growth rate implied byR_t[1]
from the latent process and the GI. Note that this matches @dylanhmorris here. The difference is I use a quick Newton method with an informed guess to do theMinor change
Aqua
kwarg topersistent_tasks = false
because locally a Turing extension was precompiling out of sequence (TBD to burrow into that).Closes #40