Fix docker image check for faster OCR deployments #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekadombek
requested review from
schreiaj,
marycrawford and
arinkulshi-skylight
derekadombek
changed the title
derekadombek
commented
Nov 4, 2024
| path: ./frontend/client.tgz | ||
| api-endpoint: https://reportvision-ocr-${{ inputs.deploy-env }}.azurewebsites.net/ | ||
| frontend-tarball: ./frontend.tgz | ||
| frontend-path: ./frontend |
There was a problem hiding this comment.
def doing a lot of scope creeping on this PR but its a needed clean-up.
derekadombek
changed the title
marycrawford
reviewed
Nov 5, 2024
| name: production-files | ||
| path: ./frontend/client.tgz | ||
| api-endpoint: https://reportvision-ocr-${{ inputs.deploy-env }}.azurewebsites.net/ | ||
| frontend-tarball: ./frontend.tgz |
There was a problem hiding this comment.
Is the npm packages being installed in the ./frontend.tgz file?
There was a problem hiding this comment.
thats correct. at least with GHA, packaging all the frontend files into a tarball/zip makes downloading from other jobs smoother.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We temporarily disabled the docker image checker cause it was bugging out, just to get the deployment automation moving forward. Now we have the time to fix it.
Screenshots (if applicable)
Related Issues
[Link any related issues or tasks from your project management system.]
Checklist