Skip to content

Commit

Permalink
removing redundant comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ericbuckley committed Sep 13, 2024
1 parent 1115760 commit 59b1666
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 23 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/check_code_vulnerabilities.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:

strategy:
matrix:
# Using a matrix in case we need to test Javascript code in the future
language: ['python']

steps:
Expand All @@ -34,4 +35,5 @@ jobs:
with:
category: "/language:${{matrix.language}}"
config: |
# only scan the code in the src directory
paths: ["src"]
4 changes: 0 additions & 4 deletions .github/workflows/check_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,20 @@ jobs:
runs-on: ubuntu-latest

steps:
# Step 1: Check out the repository
- name: Checkout code
uses: actions/checkout@v3

# Step 2: Set up Python
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.11'
cache: 'pip'

# Step 3: Install dependencies
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install '.[dev]'
# Step 4: Run lint checks
- name: Run lint checks
run: |
ruff check src/
22 changes: 3 additions & 19 deletions .github/workflows/check_unit_tests.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
name: unit tests check

# When the workflow will be triggered
on:
push:
branches: [main]
Expand All @@ -13,50 +12,35 @@ jobs:

services:
postgres:
image: postgres:13 # Use the latest version of PostgreSQL you need
image: postgres:13
ports:
- 5432:5432
env:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: pw
POSTGRES_DB: testdb
options: >-
--health-cmd "pg_isready -U testuser"
--health-interval 10s
--health-timeout 5s
--health-retries 5

steps:
# Step 1: Check out the repository
- name: Checkout code
uses: actions/checkout@v3

# Step 2: Set up Python
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.11'
cache: 'pip'

# Step 3: Install dependencies
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install '.[dev]'
# Step 4: Wait for PostgreSQL to be ready
- name: Wait for PostgreSQL to be ready
run: |
until pg_isready -h localhost -p 5432 -U postgres; do
echo "Waiting for PostgreSQL to be ready..."
sleep 1
done
until pg_isready -U postgres; do sleep 1; done
# Step 5: Run the tests
- name: Run unit tests
env:
MPI_DB_TYPE: postgres
MPI_DBNAME: testdb
MPI_DBNAME: postgres
MPI_HOST: localhost
MPI_PORT: 5432
MPI_USER: postgres
Expand Down

0 comments on commit 59b1666

Please sign in to comment.