-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the post-page-artifact job #456
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 41 41
Lines 949 949
=======================================
Hits 916 916
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Will this update when there are new commits to the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest either adding comment updating (versus reposting) before merging or alternatively waiting for the cfa-actions
repo and just pointing to that. Defer to @damonbayer on which.
Let’s wait for the CFA actions repo. Will be thrilled to add that when it is available, but closing for now. |
@damonbayer, I just re-opened this using the new CDC/cfa-actions/post-artifact action. |
@gvegayon is it working as you expect? I'm a bit confused by the two comments from the bot. |
Is the first comment just from the reopening of the issue? |
I note that the second auto comment (which reflects the new action) was posted and then edited twice, which lines up with @gvegayon's three commits since reopening (the first of which switched to the new action) |
Yupi!! |
Using the gh cli interface, this update to the pkgdown workflow posts a comment to the PR linking to the pages artifact for easy download.