Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multidimensional array convention #445

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Sep 13, 2024

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.03%. Comparing base (3d06ab9) to head (06458fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          42       42           
  Lines         989      989           
=======================================
  Hits          930      930           
  Misses         59       59           
Flag Coverage Δ
unittests 94.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review September 13, 2024 16:33
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dylanhmorris dylanhmorris merged commit ade84ce into main Sep 13, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the 443-document-the-convention-that-the-first-axis-is-time-whenever-a-multi-dimensional-array-is-a-timeseries branch September 13, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the convention that the first axis is time whenever a multi-dimensional array is a timeseries
2 participants