Refactoring the periodic broadcaster and added warn + error + test

[gvegayon]

This PR does the following:

• Refactors PeriodicBroadcaster from a class to a factory (like with the scanner functions).
• Raises a warning if, during the factory of a tiling broadcaster, the user passes period size, which is only needed for the repeat broadcaster.
• Raises an error if the requested size of the broadcaster surpasses the maximum length in a repeat broadcaster.
• Adds explicit tests for PeriodicBroadcaster.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (a131fe2) to head (db59cba).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   93.24%   93.17%   -0.07%     
==========================================
  Files          39       39              
  Lines         918      909       -9     
==========================================
- Hits          856      847       -9     
  Misses         62       62              

Flag	Coverage Δ
unittests	93.17% <100.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[damonbayer]

Thanks @gvegayon! What do we gain by implementing a factory? It seems to me that we could have two functions tile_until_n(data, n, offset = 0) and repeat_until_n(data, reps, n, offset = 0)? Since they require different arguments, I feel that implementing them in the same factory is not as readable or efficient as just creating the two functions.

[gvegayon]

Thanks @gvegayon! What do we gain by implementing a factory? It seems to me that we could have two functions tile_until_n(data, n, offset = 0) and repeat_until_n(data, reps, n, offset = 0)? Since they require different arguments, I feel that implementing them in the same factory is not as readable or efficient as just creating the two functions.

The refactoring reduced code size. Keeping both in the same also saved some code, but I do like the look of what you are proposing.

[damonbayer]

@gvegayon Based on the thumbs up / responses to #349 (comment), I request that you please do something like is suggested in the comment.

[damonbayer]

I think the description of the offset parameter in repeat_until_n is incorrect.

[dylanhmorris]

Minor suggestions

[dylanhmorris]

LGTM, thanks @gvegayon

offset parameter description now addressed