Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrading java to 21 - and resolve dependencies vulnerability #221

Merged
merged 7 commits into from
Sep 25, 2024
Merged

upgrading java to 21 - and resolve dependencies vulnerability #221

merged 7 commits into from
Sep 25, 2024

Conversation

ndduc01
Copy link
Collaborator

@ndduc01 ndduc01 commented Sep 24, 2024 •
edited
Loading

Upgrade java to 21 for these follow services

  • HL7 parser -> 21
  • CDA schema -> 21
  • Data Ingestion -> 21
  • Data Processing -> 21
    Resolving several dependency vulnerabilities

@ndduc01 ndduc01 marked this pull request as ready for review September 24, 2024 23:36
@ndduc01 ndduc01 changed the title upgrading java to 17 - and resolve dependencies vulnerability upgrading java to 21 - and resolve dependencies vulnerability Sep 25, 2024
rshanmugam-enquizit
rshanmugam-enquizit requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@rshanmugam-enquizit rshanmugam-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, please fix the code smells in the last sonar run

.github/workflows/Build-and-deploy-data-ingestion-and-processing.yaml Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

rshanmugam-enquizit
rshanmugam-enquizit approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@rshanmugam-enquizit rshanmugam-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ndduc01 ndduc01 merged commit 9687d64 into main Sep 25, 2024
2 checks passed
@ndduc01 ndduc01 deleted the DEV-DN-VUL-2 branch October 17, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshanmugam-enquizit rshanmugam-enquizit rshanmugam-enquizit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndduc01 @rshanmugam-enquizit