Migrate bloc to v8

[rajoriaakash]

Fixes #9

[techno-disaster]

Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

[techno-disaster]

ci fails due to formatting issues, can you fix that?

[rajoriaakash]

ci fails due to formatting issues, can you fix that?

Hi, i don't have knowledge on ci/cd pipeline but I can surely try 😄.. although it would take some time

[rajoriaakash]

I think flutter analyze should be run before flutter format in workflows as running flutter format first isn't helping in identifying issues.

Although I'm not sure that this commit won't fail :)

[techno-disaster]

Looks unrelated

[rajoriaakash]

I'll try to fix CI failure

[rajoriaakash]

Could you please run the checks again?

[techno-disaster]

Looks like formatting still fails could you run

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 

[rajoriaakash]

Looks like formatting still fails could you run

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 

I sorted the imports

[rajoriaakash]

@techno-disaster, please run the tests again :)

[rajoriaakash]

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

[techno-disaster]

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 
flutter test

should be enough I guess

[rajoriaakash]

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 
flutter test

should be enough I guess

thanks !

[rajoriaakash]

I think it should work now :")

[techno-disaster]

Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

@rajoriaakash were you able to look into this?

[rajoriaakash]

Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

@rajoriaakash were you able to look into this?

I haven't looked into it as of now, will look.
This build_linux test is failing due to the package manager ig and is unrelated to my changes.

[rajoriaakash]

I checked all the options from bloc_concurrency and idts it would fail on any of them. Although I think sequential is good to go.

[techno-disaster]

Yep SGTM, the default was sequential anyway. Thanks for your work! A couple of merge conflicts, do you think you can fix them anytime soon?

Also bloc v9 is a thing but should be easy to migrate afaik.