Added Drag And Drop Support For The Desktop Application

[manoj1749]

• This pr will be resolving the issue Dnd support on desktop #6 and CCExtractor
  ccextractor/issue-1413
• Using desktop_drop package I had addes the drag and drop feature which works same as the AddFilesButton.

Working Video

dnd_working.mp4

[techno-disaster]

Can you make the whole windows the drop target and keep the button labelled "Add files"?

[manoj1749]

Can you make the whole windows the drop target and keep the button labelled "Add files"?

Yeah I can do that

[manoj1749]

• Heyy @techno-disaster , as you asked I had deleted the changes made on AddFilesButton.
• Added the drag and drop feature for the whole window.

Working Video

updated_dnd.mp4

[techno-disaster]

LGTM, one small change, upon hover can you change the drop area to "drop files here" or something similar?

[techno-disaster]

also formatting and stuff, ci fails atm

[manoj1749]

I think it was due to the flutter format command as if you check the log in line 37 it states " [!] The "format" command is deprecated and will be removed in a future version of Flutter. Please use the "dart format" sub-command instead, which takes all of the same command-line arguments as "flutter format". 37 "

[manoj1749]

LGTM, one small change, upon hover can you change the drop area to "drop files here" or something similar?

ok will try to do that

[manoj1749]

Heyy, @techno-disaster , I've tried to do what you said and basically the text in the drop area is a seperate widget and it's state can't be updated whenever we move files into the window to drop.
And also look into the thing about the flutter format test, if it fails again I will update the workflows folder and check if the same error is given or not.

[techno-disaster]

Heyy, @techno-disaster , I've tried to do what you said and basically the text in the drop area is a seperate widget and it's state can't be updated whenever we move files into the window to drop. And also look into the thing about the flutter format test, if it fails again I will update the workflows folder and check if the same error is given or not.

Why not? maybe you can try listening to onDragEntered and onDragExited to update that state? lift up a variable? The formatting workflow is correct, just run the required commands #37 (comment)

[manoj1749]

Heyy, @techno-disaster , I've tried to do what you said and basically the text in the drop area is a seperate widget and it's state can't be updated whenever we move files into the window to drop. And also look into the thing about the flutter format test, if it fails again I will update the workflows folder and check if the same error is given or not.

Why not? maybe you can try listening to onDragEntered and onDragExited to update that state? lift up a variable? The formatting workflow is correct, just run the required commands #37 (comment)

Ohk, Thanks for suggesting it, I will work on it and update you soon

[manoj1749]

• Now Dashboard updates its state everytime based on the onDragEntered and onDragExited as the user interacts with the files on the dashboard as shown in the video below

dnd_updated.mp4

[manoj1749]

• Heyy @techno-disaster flutter test is running fine without errors

• should I need to test it in windows?

[techno-disaster]

Strange, they should work in the ci too. Looks like something is wrong with bloc_test.dart? Can you confirm if it works on flutter 3.7.3?

[manoj1749]

Strange, they should work in the ci too. Looks like something is wrong with bloc_test.dart? Can you confirm if it works on flutter 3.7.3?

You mean the flutter version I am using?

[techno-disaster]

yep, if yes maybe look into why ci tests are failing too :D

[manoj1749]

yep, if yes maybe look into why ci tests are failing too :D

The version I had is 3.3.9, I had tried googling about the error but what I can find is problem with the bloc_test.dart
but I am not able to figure out what is wrong in it, can you help me out?

[techno-disaster]

Try upgrading to 3.7.3, the bloc test probably shows some analyzer warnings and breaks locally then too.

[manoj1749]

Try upgrading to 3.7.3, the bloc test probably shows some analyzer warnings and breaks locally then too.

Yeah I had upgraded to 3.7.3, it's showing an error same as the one which we are getting in the CI tests

[manoj1749]

As from what I had seen, the error is due to the package called file, as you can see it from the error

./../../.pub-cache/hosted/pub.dev/file-6.1.0/lib/src/forwarding/forwarding_file.dart:18:16: Error: The
method 'ForwardingFile.create' has fewer named arguments than those of overridden method 'File.create'.
  Future<File> create({bool recursive = false}) async =>
               ^
org-dartlang-sdk:///third_party/dart/sdk/lib/io/file.dart:232:16: Context: This is the overridden method
('create').
  Future<File> create({bool recursive = false, bool exclusive = false});
               ^
../../../.pub-cache/hosted/pub.dev/file-6.1.0/lib/src/forwarding/forwarding_file.dart:18:16: Error: The
method 'ForwardingFile.create' doesn't have the named parameter 'exclusive' of overridden method
'File.create'.
  Future<File> create({bool recursive = false}) async =>
               ^
org-dartlang-sdk:///third_party/dart/sdk/lib/io/file.dart:232:16: Context: This is the overridden method
('create').
  Future<File> create({bool recursive = false, bool exclusive = false});
               ^
../../../.pub-cache/hosted/pub.dev/file-6.1.0/lib/src/forwarding/forwarding_file.dart:22:8: Error: The method
'ForwardingFile.createSync' has fewer named arguments than those of overridden method 'File.createSync'.
  void createSync({bool recursive = false}) =>
       ^
org-dartlang-sdk:///third_party/dart/sdk/lib/io/file.dart:248:8: Context: This is the overridden method
('createSync').
  void createSync({bool recursive = false, bool exclusive = false});
       ^
../../../.pub-cache/hosted/pub.dev/file-6.1.0/lib/src/forwarding/forwarding_file.dart:22:8: Error: The method
'ForwardingFile.createSync' doesn't have the named parameter 'exclusive' of overridden method
'File.createSync'.
  void createSync({bool recursive = false}) =>
       ^
org-dartlang-sdk:///third_party/dart/sdk/lib/io/file.dart:248:8: Context: This is the overridden method
('createSync').
  void createSync({bool recursive = false, bool exclusive = false});

[manoj1749]

Solved the issues, ci tests are not failing, @techno-disaster now the tests are not failing in anything

[techno-disaster]

LGTM, nice work!

[manoj1749]

Thanks😁