-
Notifications
You must be signed in to change notification settings - Fork 461
[FIX] Fixed Unit Test Rust based on the new changes on Rust 1.86.0 #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@steel-bucket Can you rebase to current master so we can get the sample platform tests to run as well? :) |
ca93fa8
to
1c6c22e
Compare
@canihavesomecoffee I have rebased to master |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 5b327c7...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
While working on the
share
module, I came across the problem that on the main branch, the Unit Test Rust(test_rust.yml) was failing. Reverting commits didn't help, later I found out that the problem was due to Rust being upgraded to 1.86.0.The New Changes to check for Null pointer De-referencing
This triggered a panic on 3 tests
test_do_cb
insrc/rust/src/lib.rs
test_process_cc_data
insrc/rust/src/decoder.rs
test_process_current_packet
insrc/rust/src/decoder.rs
The errors were fixed by checking for null pointers and reverting to a fallback value when true. I have used Box::leak in
decoder.rs
for now, it may be changed to a safer alternative later.How to replicate the errors for the main branch
git clone https://github.com/CCExtractor/ccextractor && cd ccextractor
cd src/rust
rustup update
rustup run 1.86.0 cargo test