-
Notifications
You must be signed in to change notification settings - Fork 460
fix: replace iconv with encoding_rs #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The failing unit test doesn't seem to be because of this change🤔 Will look into it later |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 9e2a594...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
It's because of the new Rust version 1.86. I've added a PR fixing it #1694 |
Ah i see, thanks |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1697
The iconv crate is currently unmaintained and broken on the latest version of rust (see this issue). This PR migrates the encoding from iconv to the well maintained encoding_rs library.
Note that the rust implementation for this particular case was and still is buggy, regression tests 142, 147 and 149 all of which test this specific scenario have historically had empty output files (see here for eg), which is why the tests were passing. The C builds however, produce the proper outputs.