Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-552 QC Error Dialog #226

Merged
merged 12 commits into from
Dec 12, 2023
Merged

CRDCDH-552 QC Error Dialog #226

merged 12 commits into from
Dec 12, 2023

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Nov 24, 2023

Overview

This PR aims to add the Error Dialog to the Data Submission Quality Control tab. It also will replace the fake dummy data with real API.

Change Details (Specifics)

  • Added Error Dialog
  • Updated submissionQCResults API query
  • Updated column names and sorting
  • Updated default rows per page to 20 for table

Related Ticket(s)

CRDCDH-552
CRDCDH-541

@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Nov 24, 2023
@Alejandro-Vega Alejandro-Vega added this to the MVP-2.1.0 (M3) milestone Nov 24, 2023
Base automatically changed from CRDCDH-541 to mvp-2.1.0 December 7, 2023 18:34
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Dec 11, 2023
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review December 11, 2023 21:36
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amattu2 amattu2 merged commit 115fd34 into mvp-2.1.0 Dec 12, 2023
1 check passed
@amattu2 amattu2 deleted the CRDCDH-552 branch December 12, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants