Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-541 QC Validation Results Table #225

Merged
merged 19 commits into from
Dec 7, 2023
Merged

CRDCDH-541 QC Validation Results Table #225

merged 19 commits into from
Dec 7, 2023

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Nov 24, 2023 •
edited
Loading

Overview

This PR aims to add the QC Validation Results Table inside the Data Submission dashboard.

Change Details (Specifics)

  • Added submissionQCResults query
  • Added QC types
  • Currently data is using dummy data and will have to be removed when backend supports the query

Related Ticket(s)

CRDCDH-541

@Alejandro-Vega Alejandro-Vega added this to the MVP-2.1.0 (M3) milestone Nov 24, 2023
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Nov 24, 2023
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Dec 6, 2023
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review December 6, 2023 20:38
amattu2
amattu2 reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Two potential issues with the column titles, but they can be pushed to the final implementation.

src/content/dataSubmissions/QualityControl.tsx Show resolved Hide resolved
src/content/dataSubmissions/QualityControl.tsx Show resolved Hide resolved
amattu2
amattu2 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding issues will be addressed in #226.

LGTM as is.

@amattu2 amattu2 merged commit 342a62c into mvp-2.1.0 Dec 7, 2023
1 check passed
@amattu2 amattu2 deleted the CRDCDH-541 branch December 7, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amattu2 amattu2 amattu2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@Alejandro-Vega @amattu2