Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-619 Fix OverlayWindow styling on DMN page #215

Merged
merged 2 commits into from
Nov 21, 2023
Merged

CRDCDH-619 Fix OverlayWindow styling on DMN page #215

merged 2 commits into from
Nov 21, 2023

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Nov 17, 2023

Overview

This PR fixes an issue where the Data Model Navigator is overriding our styling for the Government Warning Banner dialog.

To Replicate:

  1. Open https://hub-dev2.datacommons.cancer.gov/model-navigator/ICDC

Change Details (Specifics)

Before:

Screenshot 2023-11-17 at 9 42 18 AM

After:

Screenshot 2023-11-17 at 9 43 32 AM

Related Ticket(s)

https://tracker.nci.nih.gov/browse/CRDCDH-619

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Nov 17, 2023
@amattu2 amattu2 added this to the MVP-2.0.0 (M2) milestone Nov 17, 2023
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Nov 21, 2023
Copy link
Contributor

@mtangmt mtangmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtangmt mtangmt merged commit 34a8bf0 into mvp-2 Nov 21, 2023
1 check passed
@mtangmt mtangmt deleted the CRDCDH-619 branch November 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants