Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DMN overriding dialog styling #223

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Nov 22, 2023

Overview

This PR addresses MUI v4 packaged with Data Model Navigator overriding the dialog styling provided by MUI v5. Visit the DMN page on DEV2 and open either the API Token Dialog or the Uploader CLI Dialog to observe the issue.

NOTE: This is similar to the fix applied in #215

Change Details (Specifics)

  • Add (a lot) of !important CSS styling flags

Related Ticket(s)

N/A

@amattu2 amattu2 added this to the MVP-2.0.0 (M2) milestone Nov 22, 2023
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alejandro-Vega Alejandro-Vega merged commit ef28dce into mvp-2 Nov 24, 2023
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the amattu2/fix-dialog-styling branch November 24, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants