-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InteractiveSegmentation] Decouple progress bar & more #146
base: master
Are you sure you want to change the base?
Conversation
void OnModuleFinished(bool ok, std::string errorMessage, mitk::LabelSetImage::Pointer result); | ||
|
||
void OnModuleProgressUpdate(int progress); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
void SetProgressBar(QProgressBar* progressBar); | ||
void OnProgressUpdateInternalReceived(int progress); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between the 2 update methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of connecting the ProgressUpdate(int) signal, with the QProgressBar's setValue(int) slot, we connect it with OnProgressUpdateInternalReceived(int), which then emits the signal. This re-emitted signal gets connected with the progress bar in the plugin.
That intermediate stage happens because the initial ProgressUpdate(int) signal doesn't belong to the class captk::InteractiveSegmentation, but a class it uses, so we can't connect it directly.
Fix #142 progress bar resetting
Fix #115 Remove QProgressBar from module
(Also includes PR #141 and PR #145 to avoid conflicts. Please review these two PRs first) (sorry for the big PR in general!)
Changelog: