-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pass QProgressBar to the modules #115
Comments
@dboun Could you give some more context about this? |
These two modules have a SetProgressBar method. This shouldn't be the case, they should have a progressUpdate signal that the plugin connects to the progress bar |
Survival doesn't even currently have a progress bar on the plugin (I may not have removed the associated function though). From what I remember survival doesn't give progress updates even in CaPTk 1.X. But I should be able to address this issue while adding progress updates, no problem. |
PR #146 now includes fixes for this for InteractiveSegmentation. |
Ok then please just remove the QProgressBar altogether from everywhere in survival. Adding progress updates is a substantial enhancement that should not be a concern for now. |
I can't find any references to QProgressBar in the current master version of survival, so it seems this is fine for now |
Happens in Interactive seg and maybe survival
The text was updated successfully, but these errors were encountered: