Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass QProgressBar to the modules #115

Open
dboun opened this issue Mar 5, 2020 · 6 comments · May be fixed by #146
Open

Don't pass QProgressBar to the modules #115

dboun opened this issue Mar 5, 2020 · 6 comments · May be fixed by #146
Assignees

Comments

@dboun
Copy link
Collaborator

dboun commented Mar 5, 2020

Happens in Interactive seg and maybe survival

@ashishsingh18
Copy link
Collaborator

@dboun Could you give some more context about this?

@dboun
Copy link
Collaborator Author

dboun commented Mar 7, 2020

These two modules have a SetProgressBar method.

This shouldn't be the case, they should have a progressUpdate signal that the plugin connects to the progress bar

@AlexanderGetka-cbica
Copy link
Collaborator

Survival doesn't even currently have a progress bar on the plugin (I may not have removed the associated function though). From what I remember survival doesn't give progress updates even in CaPTk 1.X. But I should be able to address this issue while adding progress updates, no problem.

@dboun dboun linked a pull request Mar 12, 2020 that will close this issue
@dboun
Copy link
Collaborator Author

dboun commented Mar 12, 2020

PR #146 now includes fixes for this for InteractiveSegmentation.

@dboun
Copy link
Collaborator Author

dboun commented Mar 12, 2020

From what I remember survival doesn't give progress updates even in CaPTk 1.X

Ok then please just remove the QProgressBar altogether from everywhere in survival. Adding progress updates is a substantial enhancement that should not be a concern for now.

@AlexanderGetka-cbica
Copy link
Collaborator

I can't find any references to QProgressBar in the current master version of survival, so it seems this is fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants