Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added details around benchcab outputs to the PR template. Fixes #517 #518

Merged

Conversation

bschroeter
Copy link
Contributor

@bschroeter bschroeter commented Jan 7, 2025

Added details to the PR template RE: benchcab outputs.

Type of change

  • CI/Workflow

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

📚 Documentation preview 📚: https://cable--518.org.readthedocs.build/en/518/

@bschroeter bschroeter requested a review from ccarouge January 7, 2025 00:03
@bschroeter bschroeter linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly just want to discuss what we want included here.

@bschroeter bschroeter requested a review from ccarouge January 8, 2025 02:28
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to approve my own text :D

@ccarouge
Copy link
Member

@bschroeter merge?

@bschroeter bschroeter merged commit 6d74bdf into main Jan 14, 2025
7 checks passed
@bschroeter bschroeter deleted the 517-update-pr-template-to-include-request-for-benchcab-outputs branch January 14, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PR template to include request for benchcab outputs
2 participants