Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template to include request for benchcab outputs #517

Closed
bschroeter opened this issue Jan 6, 2025 · 0 comments · Fixed by #518
Closed

Update PR template to include request for benchcab outputs #517

bschroeter opened this issue Jan 6, 2025 · 0 comments · Fixed by #518
Assignees

Comments

@bschroeter
Copy link
Contributor

In order to expedite code review, the onus should be on the code author to provide test results that the code change still permits CABLE to compile and run without error. The simplest way to do this is to include a benchcab step with bitwise comparison, as it will cover both situations.

A simple update to the PR template should be sufficient to encourage authors to get in the habit of testing with benchcab prior to requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant