You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to expedite code review, the onus should be on the code author to provide test results that the code change still permits CABLE to compile and run without error. The simplest way to do this is to include a benchcab step with bitwise comparison, as it will cover both situations.
A simple update to the PR template should be sufficient to encourage authors to get in the habit of testing with benchcab prior to requesting a review.
The text was updated successfully, but these errors were encountered:
In order to expedite code review, the onus should be on the code author to provide test results that the code change still permits CABLE to compile and run without error. The simplest way to do this is to include a benchcab step with bitwise comparison, as it will cover both situations.
A simple update to the PR template should be sufficient to encourage authors to get in the habit of testing with benchcab prior to requesting a review.
The text was updated successfully, but these errors were encountered: