Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin error handling #17

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Plugin error handling #17

merged 9 commits into from
Sep 10, 2024

Commits on Sep 9, 2024

  1. Plugin error handling

    Brainicism committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    78a39f0 View commit details
    Browse the repository at this point in the history
  2. [plugin/misc] cleanup

    * allow custom http server base url by passing argument `getpot_bgutil_baseurl` (defaults to `http://127.0.0.1:4416`)
    * Code formatting(use single quotes): be consistent, remove trailing whitespaces
    * Use `yt_dlp.utils.Popen` instead of `subprocess.Popen`
    * Add cause to several `RequestError`'s
    * Do not use bare `except`
    [server] add options to main.ts, misc
    * generate_once.ts: Remove repeated logging
    * main.ts: allow custom http server port by passing `-p, --port <PORT>` (defaults to 4416)
    * main.ts: allow verbose logging for `SessionManager` by passing argument `--verbose`
    * main.ts: return a JSON object when it fails to generate a visitordata
    grqz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8eb6db2 View commit details
    Browse the repository at this point in the history
  3. Update README.md

    Co-authored-by: N/Ame <[email protected]>
    Brainicism and grqz authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b7081b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e1f7711 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9acc0f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. [plugin] cleanup

    * code formatting
    * be consistent(`encode()`, `decode()`): remove redundant arg `'utf-8'`
    * be consistent: deal with invalid parameter (i.e. `base_url is None`) inside the function
    * use `json.load` to read response
    * no longer passes `cause` to the `RequestError` constructor as it is useless when a message is present, move the cause to the message
    * logging: improve clarity
    grqz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d2682e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    19f84a6 View commit details
    Browse the repository at this point in the history
  3. Add quotes

    Brainicism committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e889d47 View commit details
    Browse the repository at this point in the history
  4. add http scheme to example

    Brainicism committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b1338b8 View commit details
    Browse the repository at this point in the history