Plugin error handling #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grqz
requested changes
Sep 9, 2024
* allow custom http server base url by passing argument `getpot_bgutil_baseurl` (defaults to `http://127.0.0.1:4416`) * Code formatting(use single quotes): be consistent, remove trailing whitespaces * Use `yt_dlp.utils.Popen` instead of `subprocess.Popen` * Add cause to several `RequestError`'s * Do not use bare `except` [server] add options to main.ts, misc * generate_once.ts: Remove repeated logging * main.ts: allow custom http server port by passing `-p, --port <PORT>` (defaults to 4416) * main.ts: allow verbose logging for `SessionManager` by passing argument `--verbose` * main.ts: return a JSON object when it fails to generate a visitordata
|
Brainicism
commented
Sep 9, 2024
Co-authored-by: N/Ame <[email protected]>
Co-authored-by: N/Ame <[email protected]>
* code formatting * be consistent(`encode()`, `decode()`): remove redundant arg `'utf-8'` * be consistent: deal with invalid parameter (i.e. `base_url is None`) inside the function * use `json.load` to read response * no longer passes `cause` to the `RequestError` constructor as it is useless when a message is present, move the cause to the message * logging: improve clarity
grqz
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.