BED-3828: Audit bare channel writes #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
superlinkx
requested changes
Nov 1, 2023
chore: update interface{} to any in affected files
irshadaj
reviewed
Nov 7, 2023
chore: keep SendAny improvement and remove the unnecessary type casting
superlinkx
approved these changes
Nov 7, 2023
irshadaj
approved these changes
Nov 7, 2023
|
After discussion with the team, some of the changes that were starting to get introduced in this MR were reverted in order to prevent scope creep. They will be addressed as a separate refactoring effort at a later time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The team identified several channel writes that could potentially lead to lock contention. While some of these cases are eventually resolved through other mechanisms, it is better to be explicit and handle context cancellation where it is expected to be handled and there is a chance that in some cases it isn’t being appropriately handled at all.