Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnrollOnBehalfOf Post Processing #176

Merged
merged 5 commits into from
Nov 2, 2023
Merged

EnrollOnBehalfOf Post Processing #176

merged 5 commits into from
Nov 2, 2023

Conversation

rvazarkar
Copy link
Contributor

Description

Wires up EnrollOnBehalfOf and adds tests

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar
chore: fix harness rep
e44c60f 
chore: remove bad allocation
@rvazarkar
Merge remote-tracking branch 'origin/adcs-poc' into enrollOnBehalfOfW…
79707a3 
…iring

# Conflicts:
#	cmd/api/src/analysis/ad/adcs_integration_test.go
#	cmd/api/src/test/integration/harnesses.go
#	packages/go/analysis/ad/adcs.go
#	packages/go/analysis/ad/queries.go
@rvazarkar rvazarkar changed the title tests: add tests for EnrollOnBehalfOf EnrollOnBehalfOf Post Processing Nov 2, 2023
@rvazarkar rvazarkar merged commit 6c813a0 into adcs-poc Nov 2, 2023
2 checks passed
@rvazarkar rvazarkar deleted the enrollOnBehalfOfWiring branch November 2, 2023 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@urangel urangel urangel approved these changes

@JonasBK JonasBK JonasBK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvazarkar @JonasBK @urangel