Initialize knockout plug-ins after template added to page #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttached to the page.
…cumstances this leads to the 'attach' event being triggered.
|
@oniseijin, sorry, only just seen this comment, but I agree that we have a collateral problem at present, and are steering people down the wrong path. I've created #1383 to address this. |
|
Dev reviewed - all good 👍 |
thanhc
added a commit
that referenced
this pull request
May 27, 2015
…ns-after-attaching Initialize knockout plug-ins after template added to page
This was referenced Jun 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request hopefully fixes these issues:
Better support for Jquery plugins within ko bindingHandlers #1372 can be tested by using the workbench page from the
easytreeapp within the easytree-brjs-spike — without this pull-request it's not possible to expand or collapse the nodes within the tree.Note: Except for the fact that CT are using their own version of
PresenterComponent, there would otherwise be a high risk this change introduces backwards compatibility issues. Even so, there may be issues even in terms of BRJS only infrastructure.