-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all references to the old Component interface #1383
Comments
|
#1390 looks good so I've moved that into |
@dchambers changes have been made in the existing PR (BladeRunnerJS/brjs-site#108). |
#1390 is causing workbenches to not load, see PR for more detials |
Apart from a single backwards compatibility test, there should be no reference to the old
Component
interface, or reliance on any of its methods, likegetElement()
.As a starter, the following areas will need to change:
SimpleFrame
and trigger theattach
event, instead of only using the deprecatedgetElement()
method.Component
interface (started in Initialize knockout plug-ins after template added to page #1379).Workbench.displayComponent()
method should triggerattach
(already done as part of Initialize knockout plug-ins after template added to page #1379).Component
should be updated too.This comment may contain more relevant information.
The text was updated successfully, but these errors were encountered: