Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to the old Component interface #1383

Closed
dchambers opened this issue May 12, 2015 · 4 comments
Closed

Remove all references to the old Component interface #1383

dchambers opened this issue May 12, 2015 · 4 comments
Assignees
Milestone

Comments

@dchambers
Copy link
Contributor

Apart from a single backwards compatibility test, there should be no reference to the old Component interface, or reliance on any of its methods, like getElement().

As a starter, the following areas will need to change:

This comment may contain more relevant information.

@ioanalianabalas
Copy link
Contributor

@andy-berry-dev
Copy link
Member

#1390 looks good so I've moved that into Test. I'd like to discuss BladeRunnerJS/brjs-site#108 though. IMO that makes the getting started guide much more complex so we should either simplify the interfaces use or not use it at all in the getting started guide (see my comment on the brjs-site PR - BladeRunnerJS/brjs-site#108 (comment)).

@andy-berry-dev
Copy link
Member

@dchambers changes have been made in the existing PR (BladeRunnerJS/brjs-site#108).

@thanhc
Copy link
Contributor

thanhc commented Jun 4, 2015

#1390 is causing workbenches to not load, see PR for more detials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants