(Sentinel) reduce spamming from dal checks, offsetchecks, and event checks #2236
Conversation
WalkthroughWalkthroughThe changes involve updating alarm handling logic across multiple files, introducing new constants Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AlarmSystem
participant WebSocket
participant DAL
User->>AlarmSystem: Trigger Check
AlarmSystem->>WebSocket: Check Last Update Offsets
WebSocket->>AlarmSystem: Return Delay Info
AlarmSystem->>DAL: Check DAL Delays
DAL->>AlarmSystem: Return DAL Delay Info
AlarmSystem->>User: Send Alarm Summary
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
node/pkg/checker/event/app.go (1)
306-313: ConsolidateAlarmOffsetPerPairdefinition.The constant
AlarmOffsetPerPairis defined multiple times across different files with the same value. To ensure maintainability and consistency, consider consolidating its definition to a single location and importing it where needed.
- Defined in:
node/pkg/checker/event/app.gonode/pkg/checker/offset/app.gonode/pkg/checker/dal/types.goAnalysis chain
Updated alarm thresholds.
The alarm thresholds are updated to use
AlarmOffsetPerPair. This change enhances the granularity of alarm reporting. Ensure that this constant is correctly defined and used consistently throughout the codebase.Verify the definitions and usage of
AlarmOffsetPerPairin the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definitions and usage of `AlarmOffsetPerPair`. # Test: Search for the definitions of the constants. Expect: Definitions in the appropriate files. rg --type go 'const AlarmOffsetPerPair' -A 2 # Test: Search for the usage of the constants. Expect: Consistent usage throughout the codebase. rg --type go 'AlarmOffsetPerPair'Length of output: 1045
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- node/pkg/checker/dal/app.go (4 hunks)
- node/pkg/checker/dal/app_test.go (1 hunks)
- node/pkg/checker/dal/types.go (1 hunks)
- node/pkg/checker/event/app.go (3 hunks)
- node/pkg/checker/offset/app.go (7 hunks)
Additional comments not posted (19)
node/pkg/checker/dal/types.go (2)
12-12: LGTM!The constant
AlarmOffsetPerPairis correctly declared.The code changes are approved.
13-13: LGTM!The constant
AlarmOffsetInTotalis correctly declared.The code changes are approved.
node/pkg/checker/dal/app_test.go (2)
38-38: LGTM!The value for "BTC" in
alarmCountMaphas been correctly updated to 10.The code changes are approved.
39-39: LGTM!The value for "ETH" in
alarmCountMaphas been correctly updated to 10.The code changes are approved.
node/pkg/checker/offset/app.go (5)
23-23: LGTM!The constant
AlarmOffsetPerPairis correctly declared.The code changes are approved.
24-24: LGTM!The constant
AlarmOffsetInTotalis correctly declared.The code changes are approved.
93-93: LGTM!The variable
localAggregateAlarmCountis correctly declared and initialized.The code changes are approved.
94-94: LGTM!The variable
globalAggregateAlarmCountis correctly declared and initialized.The code changes are approved.
Line range hint
136-193: LGTM!The function
checkOffsetsis correctly implemented. It includes logic to increment alarm counts based on delay and generate messages accordingly.The code changes are approved.
node/pkg/checker/dal/app.go (7)
32-32: Introduction ofwebsocketNotPushedCount.The new variable
websocketNotPushedCountis introduced to track the number of symbols for which the WebSocket has not been pushed. This improves the granularity of alarm reporting.The code changes are approved.
50-52: Summary message for WebSocket not being pushed.If any symbols have not been pushed, a summary message is appended to the
messagesslice. This provides a clear and concise summary of the issue.The code changes are approved.
156-156: Introduction oftotalDelayed.The new variable
totalDelayedis introduced to track the number of delayed price updates. This improves the granularity of alarm reporting.The code changes are approved.
186-188: Summary message for delayed price updates.If any symbols have delayed price updates, a summary message is appended to the
msgstring. This provides a clear and concise summary of the issue.The code changes are approved.
38-43: Updated alarm thresholds.The alarm thresholds are updated to use
AlarmOffsetPerPairandAlarmOffsetInTotal. This change enhances the granularity of alarm reporting. Ensure that these constants are correctly defined and used consistently throughout the codebase.Verify the definitions and usage of
AlarmOffsetPerPairandAlarmOffsetInTotalin the codebase.Verification successful
Constants are consistently defined and used.
The constants
AlarmOffsetPerPairandAlarmOffsetInTotalare consistently defined and used across the codebase with the same values. This confirms the update enhances the granularity of alarm reporting as intended. No further action is needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definitions and usage of `AlarmOffsetPerPair` and `AlarmOffsetInTotal`. # Test: Search for the definitions of the constants. Expect: Definitions in the appropriate files. rg --type go 'const AlarmOffsetPerPair' -A 2 rg --type go 'const AlarmOffsetInTotal' -A 2 # Test: Search for the usage of the constants. Expect: Consistent usage throughout the codebase. rg --type go 'AlarmOffsetPerPair' rg --type go 'AlarmOffsetInTotal'Length of output: 1941
240-240: Updated alarm thresholds.The alarm thresholds are updated to use
AlarmOffsetPerPair. This change enhances the granularity of alarm reporting. Ensure that this constant is correctly defined and used consistently throughout the codebase.Verify the definitions and usage of
AlarmOffsetPerPairin the codebase.Verification successful
Consistent definition and usage of
AlarmOffsetPerPair.The constant
AlarmOffsetPerPairis consistently defined and used across the codebase with a value of 10. This ensures uniform alarm threshold behavior across different modules. No issues found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definitions and usage of `AlarmOffsetPerPair`. # Test: Search for the definitions of the constants. Expect: Definitions in the appropriate files. rg --type go 'const AlarmOffsetPerPair' -A 2 # Test: Search for the usage of the constants. Expect: Consistent usage throughout the codebase. rg --type go 'AlarmOffsetPerPair'Length of output: 1045
174-178: Updated alarm thresholds.The alarm thresholds are updated to use
AlarmOffsetPerPairandAlarmOffsetInTotal. This change enhances the granularity of alarm reporting. Ensure that these constants are correctly defined and used consistently throughout the codebase.Verify the definitions and usage of
AlarmOffsetPerPairandAlarmOffsetInTotalin the codebase.Verification successful
Alarm thresholds are consistently defined and used.
The constants
AlarmOffsetPerPairandAlarmOffsetInTotalare correctly defined and consistently used throughout the codebase, enhancing the granularity of alarm reporting as intended.
- Defined in
node/pkg/checker/event/app.goandnode/pkg/checker/dal/types.go.- Used in
node/pkg/checker/dal/app.go,node/pkg/checker/offset/app.go, andnode/pkg/checker/event/app.go.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definitions and usage of `AlarmOffsetPerPair` and `AlarmOffsetInTotal`. # Test: Search for the definitions of the constants. Expect: Definitions in the appropriate files. rg --type go 'const AlarmOffsetPerPair' -A 2 rg --type go 'const AlarmOffsetInTotal' -A 2 # Test: Search for the usage of the constants. Expect: Consistent usage throughout the codebase. rg --type go 'AlarmOffsetPerPair' rg --type go 'AlarmOffsetInTotal'Length of output: 1941
node/pkg/checker/event/app.go (3)
148-148: Introduction oftotalDelayed.The new variable
totalDelayedis introduced to track the number of delayed feeds. This improves the granularity of alarm reporting.The code changes are approved.
170-171: Summary message for delayed feeds.If any feeds are delayed, a summary message is appended to the
msgstring. This provides a clear and concise summary of the issue.The code changes are approved.
157-167: Updated alarm thresholds.The alarm thresholds are updated to use
AlarmOffsetPerPairandAlarmOffsetInTotal. This change enhances the granularity of alarm reporting. Ensure that these constants are correctly defined and used consistently throughout the codebase.Verify the definitions and usage of
AlarmOffsetPerPairandAlarmOffsetInTotalin the codebase.Verification successful
Verification Successful: Consistent Definitions and Usage of Alarm Thresholds
The constants
AlarmOffsetPerPairandAlarmOffsetInTotalare consistently defined and used across the codebase. They are defined with the same values in multiple files and are applied uniformly in various parts of the code. No discrepancies were found.
AlarmOffsetPerPairis defined with a value of 10.AlarmOffsetInTotalis defined with a value of 3.These constants are used in
node/pkg/checker/event/app.go,node/pkg/checker/dal/app.go, andnode/pkg/checker/offset/app.go.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definitions and usage of `AlarmOffsetPerPair` and `AlarmOffsetInTotal`. # Test: Search for the definitions of the constants. Expect: Definitions in the appropriate files. rg --type go 'const AlarmOffsetPerPair' -A 2 rg --type go 'const AlarmOffsetInTotal' -A 2 # Test: Search for the usage of the constants. Expect: Consistent usage throughout the codebase. rg --type go 'AlarmOffsetPerPair' rg --type go 'AlarmOffsetInTotal'Length of output: 1941
Description
Alarm per pair will be sent with 10 times of offset,
for less occurrences, it'll send cnt message for previous offset
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment