Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.1, Ruby 3.1, and Ruby 3.2 #15

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Rails 7.1, Ruby 3.1, and Ruby 3.2 #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d2167d
Add rails 7.1 appraisal
smudge Jul 20, 2023
6ea1347
Address DevelopmentDependencies linter
smudge Oct 6, 2023
d4a9c83
Unpin rspec
smudge Oct 6, 2023
567ce4e
Exclude 2.6 + 7.1
smudge Oct 6, 2023
4f51171
Use stringy versions to avoid 3.0 becomeing 3-latest
smudge Oct 6, 2023
ce487d2
Bump version
smudge Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,27 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.6, 2.7, 3.0]
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to drop Ruby < 3 support in the next major release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about unsupported rails versions? those too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those too I think.

gemfile:
- gemfiles/rails_5_2.gemfile
- gemfiles/rails_6_0.gemfile
- gemfiles/rails_6_1.gemfile
- gemfiles/rails_7_0.gemfile
- gemfiles/rails_7_1.gemfile
exclude:
- ruby: 3.0
- ruby: '3.2'
gemfile: gemfiles/rails_5_2.gemfile
- ruby: 2.6
- ruby: '3.1'
gemfile: gemfiles/rails_5_2.gemfile
- ruby: '3.0'
gemfile: gemfiles/rails_5_2.gemfile
- ruby: '2.7'
gemfile: gemfiles/rails_7_1.gemfile
- ruby: '2.7'
gemfile: gemfiles/rails_7_0.gemfile
- ruby: '2.6'
gemfile: gemfiles/rails_7_1.gemfile
- ruby: '2.6'
gemfile: gemfiles/rails_7_0.gemfile

steps:
Expand Down
3 changes: 0 additions & 3 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ inherit_gem:
betterlint:
- config/default.yml

Gemspec/DevelopmentDependencies:
Enabled: false

AllCops:
NewCops: enable
TargetRubyVersion: 2.6
4 changes: 4 additions & 0 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ end
appraise 'rails-7-0' do
gem 'railties', '~> 7.0.0'
end

appraise 'rails-7-1' do
gem 'railties', '~> 7.1.0'
end
6 changes: 6 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
source 'https://rubygems.org'

gemspec

gem 'appraisal', '~> 2.2.0'
gem 'betterlint'
gem 'rails'
gem 'rspec'
gem 'timecop', '~> 0.9.1'
5 changes: 5 additions & 0 deletions gemfiles/rails_5_2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

source "https://rubygems.org"

gem "appraisal", "~> 2.2.0"
gem "betterlint"
gem "rails"
gem "railties", "~> 5.2.0"
gem "rspec"
gem "timecop", "~> 0.9.1"

gemspec path: "../"
5 changes: 5 additions & 0 deletions gemfiles/rails_6_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

source "https://rubygems.org"

gem "appraisal", "~> 2.2.0"
gem "betterlint"
gem "rails"
gem "railties", "~> 6.0.0"
gem "rspec"
gem "timecop", "~> 0.9.1"

gemspec path: "../"
5 changes: 5 additions & 0 deletions gemfiles/rails_6_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

source "https://rubygems.org"

gem "appraisal", "~> 2.2.0"
gem "betterlint"
gem "rails"
gem "railties", "~> 6.1.0"
gem "rspec"
gem "timecop", "~> 0.9.1"

gemspec path: "../"
5 changes: 5 additions & 0 deletions gemfiles/rails_7_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

source "https://rubygems.org"

gem "appraisal", "~> 2.2.0"
gem "betterlint"
gem "rails"
gem "railties", "~> 7.0.0"
gem "rspec"
gem "timecop", "~> 0.9.1"

gemspec path: "../"
12 changes: 12 additions & 0 deletions gemfiles/rails_7_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "appraisal", "~> 2.2.0"
gem "betterlint"
gem "rails"
gem "railties", "~> 7.1.0"
gem "rspec"
gem "timecop", "~> 0.9.1"

gemspec path: "../"
2 changes: 1 addition & 1 deletion lib/uncruft/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Uncruft
VERSION = '0.3.3'.freeze
VERSION = '0.3.4'.freeze
end
6 changes: 0 additions & 6 deletions uncruft.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,4 @@ Gem::Specification.new do |s|
s.required_ruby_version = '>= 2.6.0'

s.add_dependency 'railties', '>= 5.2.0'

s.add_development_dependency 'appraisal', '~> 2.2.0'
s.add_development_dependency 'betterlint'
s.add_development_dependency 'rails'
s.add_development_dependency 'rspec', '~> 3.7.0'
s.add_development_dependency 'timecop', '~> 0.9.1'
end