Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.1, Ruby 3.1, and Ruby 3.2 #15

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Conversation

smudge
Copy link
Member

@smudge smudge commented Oct 6, 2023

This adds Rails 7.1, Ruby 3.1, and Ruby 3.2 to the build matrix.

The gem already works with these versions, but now they are formally tested. (As such, I bumped the gem by a patch version, to signify that this is the first verified-compatible release.)

@@ -12,16 +12,27 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.6, 2.7, 3.0]
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to drop Ruby < 3 support in the next major release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about unsupported rails versions? those too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those too I think.

Copy link
Member

@samandmoore samandmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainlgtm

Copy link
Member

@samandmoore samandmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platformlgtm too

when do you think you'll wanna do the major release to cut old versions?

@smudge
Copy link
Member Author

smudge commented Oct 9, 2023

@samandmoore I have a branch where I've been experimenting with more fully decoupling this gem from rails, so that it can be used more readily in standalone Ruby apps/gems. That's what I was targeting as the next major release.

@smudge smudge merged commit be12db0 into Betterment:main Oct 9, 2023
18 checks passed
@smudge smudge deleted the rails-7-1 branch October 9, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants