Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured Chart #18

Merged
merged 8 commits into from
Nov 20, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ e2e-helm-deploy:
mkdir -p .staging/helm
curl https://get.helm.sh/helm-v${HELM_VERSION}-linux-amd64.tar.gz > .staging/helm/helmbin.tar.gz
cd .staging/helm && tar -xvf helmbin.tar.gz
./.staging/helm/linux-amd64/helm install osm ./charts/osm --namespace arc-osm-system
./.staging/helm/linux-amd64/helm dependency update ./charts/osm-arc
./.staging/helm/linux-amd64/helm install osm ./charts/osm-arc --namespace arc-osm-system

test-e2e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a new Makefile target similar to this example. We can run this target before cutting a release of osm-arc to ensure the osm chart has been updated and included as part of the new release of osm-arc chart.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should create an issue for this... called create helm-lint Makefile target which does a helm dep update before linting the osm-arc chart.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #21

bats -t test/bats/test.bats
Expand Down
23 changes: 23 additions & 0 deletions charts/osm-arc/.helmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Patterns to ignore when building packages.
# This supports shell glob matching, relative path matching, and
# negation (prefixed with !). Only one pattern per line.
.DS_Store
# Common VCS dirs
.git/
.gitignore
.bzr/
.bzrignore
.hg/
.hgignore
.svn/
# Common backup files
*.swp
*.bak
*.tmp
*.orig
*~
# Various IDEs
.project
.idea/
*.tmproj
.vscode/
6 changes: 6 additions & 0 deletions charts/osm-arc/Chart.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
dependencies:
- name: osm
repository: file://../../charts/osm
version: 0.5.0-rc.1
digest: sha256:d1226533d04b95e18f2f0763a5c8a0bef8378917c5c7dbca83a84194cdf6eebb
generated: "2020-11-11T19:27:13.3389966-05:00"
29 changes: 29 additions & 0 deletions charts/osm-arc/Chart.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
apiVersion: v2
name: osm-arc
description: A Helm chart for Kubernetes

# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into versioned archives
# to be deployed.
#
# Library charts provide useful utilities or functions for the chart developer. They're included as
# a dependency of application charts to inject those utilities and functions into the rendering
# pipeline. Library charts do not define any templates and therefore cannot be deployed.
type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.5.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: v0.5.0

dependencies:
- name: osm
version: "0.5.0-rc.1"
repository: "file://../../charts/osm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelleN I noticed we dont have index.yaml in https://github.com/openservicemesh/osm/tree/main/charts/osm is that going to be an issue finding older versions of the osm chart?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The serve the osm chart repository via github pages so the index file lives here. If folks want to see a chart for a particular version of helm, they can checkout the tag for that version of osm. If folks want to see a chart at a particular version, they can check out the tag called chart/vX.Y.Z where X.Y.Z is the version they're looking for.


Binary file added charts/osm-arc/charts/osm-0.5.0-rc.1.tgz
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: osm-label-account
namespace: {{ .Values.OpenServiceMesh.namespace }}
namespace: {{ .Release.Namespace }}
annotations:
"helm.sh/hook-weight": "20"
"helm.sh/hook": pre-install
Expand Down Expand Up @@ -37,7 +37,7 @@ metadata:
subjects:
- kind: ServiceAccount
name: osm-label-account
namespace: {{ .Values.OpenServiceMesh.namespace }}
namespace: {{ .Release.Namespace }}
roleRef:
kind: ClusterRole
name: osm-label-cluster-role
Expand All @@ -55,7 +55,7 @@ metadata:
subjects:
- kind: ServiceAccount
name: osm-label-account
namespace: {{ .Values.OpenServiceMesh.namespace }}
namespace: {{ .Release.Namespace }}
roleRef:
kind: ClusterRole
name: osm-label-cluster-role
Expand All @@ -73,7 +73,7 @@ metadata:
subjects:
- kind: ServiceAccount
name: osm-label-account
namespace: {{ .Values.OpenServiceMesh.namespace }}
namespace: {{ .Release.Namespace }}
roleRef:
kind: ClusterRole
name: osm-label-cluster-role
Expand All @@ -83,7 +83,7 @@ apiVersion: batch/v1
kind: Job
metadata:
name: osm-label
namespace: {{ .Values.OpenServiceMesh.namespace }}
namespace: {{ .Release.Namespace }}
annotations:
"helm.sh/hook-weight": "35"
"helm.sh/hook": pre-install
Expand All @@ -109,7 +109,7 @@ spec:
- name: labelnamespaces
value: {{ .Values.OpenServiceMesh.ignoreNamespaces }}
- name: osmnamespace
value: {{ .Values.OpenServiceMesh.namespace }}
value: {{ .Release.Namespace }}
securityContext:
allowPrivilegeEscalation: false
command:
Expand Down
29 changes: 29 additions & 0 deletions charts/osm-arc/values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Default values for osm-arc.
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.
OpenServiceMesh:
ignoreNamespaces: "kube-system azure-arc arc-osm-system"

osm:
OpenServiceMesh:
enableDebugServer: true
enablePermissiveTrafficPolicy: true
enableFluentbit: true
fluentBitImage:
name: fluentbit-logger
registry: "mcr.microsoft.com/oss/fluent"
tag: "v1.6.2"
pullPolicy: IfNotPresent
enforceSingleMesh: true
enablePrometheus: false
deployJaeger: false
customLogAnalyticsWorkspace: false
customerID: 49a4d43a-81ef-4607-83f6-a13872c6ae60
sharedKey: 5q+pyUKQtxtef8ZGTb+aYYcFWR54lmtXpA0AYWJSqUOGBRd9AHgDZZmb0uuLpjOjIMZTp+F3F4e5JUMOWUmHHw==
fluentbitOutput: azure
webhookConfigNamePrefix: arc-osm-webhook

alpine:
image:
name: "mcr.microsoft.com/azure-policy/alpine"
tag: "prod_20200505.1"
6 changes: 6 additions & 0 deletions charts/osm/Chart.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
dependencies:
- name: osm-arc
repository: file://../../charts/osm-arc
version: 0.1.0
digest: sha256:d86a5f1460388d13ef009984e1a2bc78a35035ac7a2e1805f1de1ea510532647
generated: "2020-11-09T19:21:38.9345356-05:00"
4 changes: 2 additions & 2 deletions charts/osm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.4.2
version: 0.5.0-rc.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.4.2
appVersion: v0.5.0-rc.1
23 changes: 12 additions & 11 deletions charts/osm/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# osm

![Version: 0.2.0](https://img.shields.io/badge/Version-0.2.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.3.0](https://img.shields.io/badge/AppVersion-v0.3.0-informational?style=flat-square)
![Version: 0.4.2](https://img.shields.io/badge/Version-0.4.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.4.2](https://img.shields.io/badge/AppVersion-v0.4.2-informational?style=flat-square)

A Helm chart to install the OSM control plane on Kubernetes

Expand All @@ -9,7 +9,7 @@ A Helm chart to install the OSM control plane on Kubernetes
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| OpenServiceMesh.caBundleSecretName | string | `"osm-ca-bundle"` | |
| OpenServiceMesh.certficateManager | string | `"tresor"` | |
| OpenServiceMesh.certificateManager | string | `"tresor"` | |
| OpenServiceMesh.certmanager.issuerGroup | string | `"cert-manager"` | |
| OpenServiceMesh.certmanager.issuerKind | string | `"Issuer"` | |
| OpenServiceMesh.certmanager.issuerName | string | `"osm-ca"` | |
Expand All @@ -18,27 +18,28 @@ A Helm chart to install the OSM control plane on Kubernetes
| OpenServiceMesh.enableDebugServer | bool | `false` | |
| OpenServiceMesh.enableEgress | bool | `false` | |
| OpenServiceMesh.enableGrafana | bool | `false` | |
| OpenServiceMesh.enablePrometheus | bool | `true` | |
| OpenServiceMesh.enableFluentbit | bool | `false` | |
| OpenServiceMesh.enablePermissiveTrafficPolicy | bool | `false` | |
| OpenServiceMesh.enablePrometheus | bool | `true` | |
| OpenServiceMesh.envoyLogLevel | string | `"error"` | |
| OpenServiceMesh.grafana.port | int | `3000` | |
| OpenServiceMesh.image.pullPolicy | string | `"IfNotPresent"` | |
| OpenServiceMesh.image.registry | string | `"openservicemesh"` | |
| OpenServiceMesh.image.tag | string | `"v0.3.0"` | |
| OpenServiceMesh.imagePullSecrets | object | `{}` | |
| OpenServiceMesh.meshCIDRRanges | string | `"0.0.0.0/0"` | |
| OpenServiceMesh.image.tag | string | `"v0.4.2"` | |
| OpenServiceMesh.imagePullSecrets | list | `[]` | |
| OpenServiceMesh.meshName | string | `"osm"` | |
| OpenServiceMesh.prometheus.port | int | `7070` | |
| OpenServiceMesh.prometheus.retention.time | string | `"15d"` | |
| OpenServiceMesh.replicaCount | int | `1` | |
| OpenServiceMesh.serviceCertValidityMinutes | int | `1` | |
| OpenServiceMesh.serviceCertValidityDuration | string | `"24h"` | |
| OpenServiceMesh.sidecarImage | string | `"envoyproxy/envoy-alpine:v1.15.0"` | |
| OpenServiceMesh.tracing.address | string | `"jaeger.osm-system.svc.cluster.local"` | |
| OpenServiceMesh.tracing.enable | bool | `true` | |
| OpenServiceMesh.tracing.endpoint | string | `"/api/v2/spans"` | |
| OpenServiceMesh.tracing.port | int | `9411` | |
| OpenServiceMesh.useHTTPSIngress | bool | `false` | |
| OpenServiceMesh.vault.host | string | `nil` | |
| OpenServiceMesh.vault.protocol | string | `"http"` | |
| OpenServiceMesh.vault.role | string | `"openservicemesh"` | |
| OpenServiceMesh.vault.token | string | `nil` | |
| OpenServiceMesh.tracing.address | string | `"jaeger.osm-system.svc.cluster.local"` | |
| OpenServiceMesh.tracing.enable | bool | `false` | |
| OpenServiceMesh.tracing.endpoint | string | `"/api/v2/spans"` | |
| OpenServiceMesh.tracing.port | int | `9411` | |
| OpenServiceMesh.enforceSingleMesh | bool | `"false"` | |
21 changes: 21 additions & 0 deletions charts/osm/crds/experimental/backpressure.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
name: backpressures.policy.openservicemesh.io
spec:
group: policy.openservicemesh.io
version: v1alpha1
names:
kind: Backpressure
plural: backpressures
singular: backpressure
scope: Namespaced
validation:
openAPIV3Schema:
properties:
spec:
properties:
maxConnections:
description: "Max number of connections"
type: integer
pattern: '^[1-9]{1}[0-9]*'
Loading