Restructured Chart #18
Conversation
| @@ -23,7 +23,8 @@ e2e-helm-deploy: | |||
| mkdir -p .staging/helm | |||
| curl https://get.helm.sh/helm-v${HELM_VERSION}-linux-amd64.tar.gz > .staging/helm/helmbin.tar.gz | |||
| cd .staging/helm && tar -xvf helmbin.tar.gz | |||
| ./.staging/helm/linux-amd64/helm install osm ./charts/osm --namespace arc-osm-system | |||
| ./.staging/helm/linux-amd64/helm dependency update ./charts/osm-arc | |||
| ./.staging/helm/linux-amd64/helm install osm ./charts/osm-arc --namespace arc-osm-system | |||
|
|
|||
| test-e2e: | |||
There was a problem hiding this comment.
We should add a new Makefile target similar to this example. We can run this target before cutting a release of osm-arc to ensure the osm chart has been updated and included as part of the new release of osm-arc chart.
There was a problem hiding this comment.
we should create an issue for this... called create helm-lint Makefile target which does a helm dep update before linting the osm-arc chart.
charts/osm-arc/Chart.yaml
Outdated
| dependencies: | ||
| - name: osm | ||
| version: "0.5.0-rc.1" | ||
| repository: "file://../../charts/osm" |
There was a problem hiding this comment.
Should this be https://github.com/openservicemesh/osm/tree/main/charts/osm?
There was a problem hiding this comment.
@michelleN I noticed we dont have index.yaml in https://github.com/openservicemesh/osm/tree/main/charts/osm is that going to be an issue finding older versions of the osm chart?
There was a problem hiding this comment.
The serve the osm chart repository via github pages so the index file lives here. If folks want to see a chart for a particular version of helm, they can checkout the tag for that version of osm. If folks want to see a chart at a particular version, they can check out the tag called chart/vX.Y.Z where X.Y.Z is the version they're looking for.
| @@ -23,7 +23,8 @@ e2e-helm-deploy: | |||
| mkdir -p .staging/helm | |||
| curl https://get.helm.sh/helm-v${HELM_VERSION}-linux-amd64.tar.gz > .staging/helm/helmbin.tar.gz | |||
| cd .staging/helm && tar -xvf helmbin.tar.gz | |||
| ./.staging/helm/linux-amd64/helm install osm ./charts/osm --namespace arc-osm-system | |||
| ./.staging/helm/linux-amd64/helm dependency update ./charts/osm-arc | |||
| ./.staging/helm/linux-amd64/helm install osm ./charts/osm-arc --namespace arc-osm-system | |||
|
|
|||
| test-e2e: | |||
There was a problem hiding this comment.
we should create an issue for this... called create helm-lint Makefile target which does a helm dep update before linting the osm-arc chart.
|
cc @snehachhabria @SanyaKochhar PTAL |
Separated this chart into two new ones: osm-arc and osm. OSM is a dependency of osm-arc, and osm-arc values will override those in the values.yaml of osm. Osm-arc will have templates, such as osm-label, that are specific for arc environments.
Now the workflow for installing the chart via helm will look something like this:
helm dependency update osm-archelm install osm osm-arc --namespace arc-osm-system