Make property type checks more robust

v2/tools/generator/internal/codegen/pipeline/apply_cross_resource_references_from_config.go

@@ -180,19 +180,31 @@ var armIDNameRegex = regexp.MustCompile("(?i)(^Id$|ResourceID|ARMID)")
 // This can be used for logging/reporting purposes to discover references which we missed.
 func DoesPropertyLookLikeARMReference(prop *astmodel.PropertyDefinition) bool {
 	// The property must be a string, optional string, list of strings, or map[string]string
-	isString := astmodel.TypeEquals(prop.PropertyType(), astmodel.StringType)
-	isOptionalString := astmodel.TypeEquals(prop.PropertyType(), astmodel.OptionalStringType)
-	isStringSlice := astmodel.TypeEquals(prop.PropertyType(), astmodel.NewArrayType(astmodel.StringType))
-	isStringMap := astmodel.TypeEquals(prop.PropertyType(), astmodel.MapOfStringStringType)
+	mightBeReference := false
+	if pt, ok := astmodel.AsPrimitiveType(prop.PropertyType()); ok {
+		// Might be a reference if we have a primitive type that's a string
+		mightBeReference = pt == astmodel.StringType
+	}
+
+	if at, ok := astmodel.AsArrayType(prop.PropertyType()); ok {
+		// Might be references if we have an array of strings
+		elementType, elementTypeIsPrimitive := astmodel.AsPrimitiveType(at.Element())
+		mightBeReference = elementTypeIsPrimitive &&
+			elementType == astmodel.StringType
+	}
 
-	if !isString && !isOptionalString && !isStringSlice && !isStringMap {
-		return false
+	if mt, ok := astmodel.AsMapType(prop.PropertyType()); ok {
+		// Might be references if we have a map of strings to strings
+		keyType, keyTypeIsPrimitive := astmodel.AsPrimitiveType(mt.KeyType())
+		valueType, valueTypeIsPrimitive := astmodel.AsPrimitiveType(mt.ValueType())
+		mightBeReference = keyTypeIsPrimitive && valueTypeIsPrimitive &&
+			keyType == astmodel.StringType && valueType == astmodel.StringType
 	}
 
 	hasMatchingName := armIDNameRegex.MatchString(prop.PropertyName().String())
 	hasMatchingDescription := armIDDescriptionRegex.MatchString(prop.Description())
 
-	if hasMatchingName || hasMatchingDescription {
+	if mightBeReference && (hasMatchingName || hasMatchingDescription) {
 		return true
 	}