Improve heuristic for detection of ARM Resource References #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3832 +/- ##
==========================================
- Coverage 53.40% 53.39% -0.02%
==========================================
Files 1510 1510
Lines 545857 545863 +6
==========================================
- Hits 291532 291471 -61
- Misses 209396 209461 +65
- Partials 44929 44931 +2 ☔ View full report in Codecov by Sentry. |
matthchr
approved these changes
Feb 28, 2024
| "github.com/go-logr/logr" | ||
| "github.com/pkg/errors" | ||
| kerrors "k8s.io/apimachinery/pkg/util/errors" | ||
| "regexp" |
There was a problem hiding this comment.
minor: stdlib, goes at the top
| @@ -20,7 +20,7 @@ import ( | |||
| // TransformCrossResourceReferencesStageID is the unique identifier for this pipeline stage | |||
| const TransformCrossResourceReferencesStageID = "transformCrossResourceReferences" | |||
|
|
|||
| var armIDDescriptionRegex = regexp.MustCompile("(?i)(.*/subscriptions/.*?/resourceGroups/.*|ARM ID|Resource ID|resourceId)") | |||
There was a problem hiding this comment.
minor: Consider either colocating this regex in the pipeline stage, or putting the new regex you added in the pipeline stage here?
It feels like the armIDDescriptionRegex and the armIDNameRegex should be together.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As detailed in #3772 we have a few properties that are ARM Resource References, but had slipped through both our heuristic and our manual checks.
This PR improves our heuristic to try and prevent future issues.
Closes #3772
How does this PR make you feel:
