Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Virtual Network Gateway query and add new query for TrafficManagerProfiles #511

Merged
merged 8 commits into from
Nov 7, 2024
Merged

fix: Update Virtual Network Gateway query and add new query for TrafficManagerProfiles #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b06ef2
fix: Update Virtual Network Gateway query
rodrigosantosms Nov 6, 2024
1813726
Generate Updated Recommendation Object [rodrigosantosms/0269bbe1]
github-actions[bot] Nov 6, 2024
5c67086
fix: adding a new query for a trafficManager recommendation
rodrigosantosms Nov 6, 2024
3c61f14
Generate Updated Recommendation Object [rodrigosantosms/0269bbe1]
github-actions[bot] Nov 6, 2024
69b1e2b
Generate Updated Recommendation Object [rodrigosantosms/0269bbe1]
github-actions[bot] Nov 6, 2024
0ca5e55
Update recommendations.yaml
rodrigosantosms Nov 6, 2024
cbd6d99
Generate Updated Recommendation Object [rodrigosantosms/0269bbe1]
github-actions[bot] Nov 6, 2024
6b558b5
Generate Updated Recommendation Object [oZakari/0269bbe1]
github-actions[bot] Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions azure-resources/Network/trafficManagerProfiles/kql/1ad9d7b7-9692-1441-a8f4-93792efbe97a.kql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,15 @@
// cannot-be-validated-with-arg

// Azure Resource Graph Query
// Find traffic manager profiles that do not have at least two endpoints in different regions
resources
| where type == "microsoft.network/trafficmanagerprofiles"
| extend endpoints = properties.endpoints
| mv-expand endpoint = endpoints
| extend endpointLocation = endpoint.properties.endpointLocation
| summarize
regions = makeset(endpointLocation),
tags = any(tags),
name = any(name)
by id
| extend regionCount = array_length(regions)
| where regionCount <= 1
| project recommendationId = "1ad9d7b7-9692-1441-a8f4-93792efbe97a", name, id, tags, param1 = regions
2 changes: 1 addition & 1 deletion azure-resources/Network/trafficManagerProfiles/recommendations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
Profiles should have multiple endpoints to ensure availability in case an endpoint fails. It's also advised to distribute these endpoints across different regions for enhanced reliability.
potentialBenefits: Enhances availability across regions
pgVerified: true
automationAvailable: false
automationAvailable: true
tags: null
learnMoreLink:
- name: Reliability recommendations
Expand Down
2 changes: 1 addition & 1 deletion azure-resources/Network/virtualNetworkGateways/kql/bbe668b7-eb5c-c746-8b82-70afdedf0cae.kql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Azure Resource Graph Query
// For all VNGs of type ExpressRoute, show all that are not zone redundant (Zonal or Regional)
advisorresources
| where properties.recommendationTypeId == 'c9af1ef6-55bc-48af-bfe4-2c80490159f8' // RecommendationID from Advisor
| where properties.recommendationTypeId =~ 'c9af1ef6-55bc-48af-bfe4-2c80490159f8' // RecommendationID from Advisor
| mv-expand resId = properties.resourceMetadata.resourceId
| extend resId = tostring(resId)
| project recId = properties.recommendationTypeId, resId
Expand Down
Loading