Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Virtual Network Gateway query and add new query for TrafficManagerProfiles #511

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

rodrigosantosms
Copy link
Contributor

@rodrigosantosms rodrigosantosms commented Nov 6, 2024

Overview/Summary

This fix is to prevent any issues with Advisor recommendations using Lower or Upper characters in its recommendation GUIDs.
It also adds a new query for traffic manager profiles, to identify profiles without at least two endpoints in different regions.

@github-actions github-actions bot requested a review from a team as a code owner November 6, 2024 16:31
ehaslett
ehaslett previously approved these changes Nov 6, 2024
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodrigosantosms rodrigosantosms changed the title fix: Update Virtual Network Gateway query fix: Update Virtual Network Gateway query and add new query for TrafficManagerProfiles Nov 6, 2024
oZakari
oZakari previously approved these changes Nov 6, 2024
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davenewman777
Copy link
Contributor

This worked in my customer environment - Good to go

Copy link
Contributor

@davenewman777 davenewman777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for my customer

oZakari
oZakari previously approved these changes Nov 7, 2024
@oZakari oZakari closed this Nov 7, 2024
auto-merge was automatically disabled November 7, 2024 02:05

Pull request was closed

@oZakari oZakari reopened this Nov 7, 2024
@oZakari oZakari disabled auto-merge November 7, 2024 02:06
@oZakari oZakari disabled auto-merge November 7, 2024 02:10
@oZakari oZakari merged commit 565f43d into main Nov 7, 2024
1 check passed
@oZakari oZakari deleted the rosanto-fix-advisor-query branch November 7, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Merge ✔️ Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants