New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update window cse to install credental provider #4281

Merged

mainred merged 16 commits into master from qinhao/credential-provider-win-cse

Apr 16, 2024

Member

mainred commented Apr 11, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

mainred requested review from juan-lee, cameronmeissner, UtheMan, ganeshkumarashok, anujmaheshwari1, AlisonB319, Devinwong, lilypan26, ShiqianTao, AbelHu, junjiezhang1997 and jason1028kr as code owners

April 11, 2024 08:56

mainred temporarily deployed to test

April 11, 2024 08:56

— with

GitHub Actions Inactive

coveralls commented Apr 11, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 8699770849

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.253%

Totals
Change from base Build 8684612162:	0.0%
Covered Lines:	2376
Relevant Lines:	2998

💛 - Coveralls


          update window cse to install credental provider

0e7cb5a

mainred force-pushed the qinhao/credential-provider-win-cse branch from d0b0a25 to 0e7cb5a Compare

April 11, 2024 09:00

mainred temporarily deployed to test

April 11, 2024 09:00

— with

GitHub Actions Inactive

This was referenced Apr 11, 2024

feat: install credential provider support for windows and cache binary in VHD #4282

Merged

feat: cse support credential provider and vhd cache binary for Linux #4258

Merged

andyzhangx reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Show resolved Hide resolved

mainred commented

View reviewed changes

staging/cse/windows/configfunc.ps1 Show resolved Hide resolved

mainred added the windows cse package label

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.tests.ps1 Show resolved Hide resolved

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Show resolved Hide resolved

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Show resolved Hide resolved

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved


          update comment and add try/catch block

becc452

mainred temporarily deployed to test

April 12, 2024 08:04

— with

GitHub Actions Inactive

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved

AbelHu reviewed

View reviewed changes

staging/cse/windows/debug/collect-windows-logs.ps1 Show resolved Hide resolved


          address comments

37731ce

mainred temporarily deployed to test

April 15, 2024 07:35

— with

GitHub Actions Inactive

AbelHu reviewed

View reviewed changes

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved

mainred temporarily deployed to test

April 15, 2024 10:20

— with

GitHub Actions Inactive


          check credential provider flags

e5106b5

mainred force-pushed the qinhao/credential-provider-win-cse branch from f5402a4 to e5106b5 Compare

April 15, 2024 14:22

mainred temporarily deployed to test

April 15, 2024 14:22

— with

GitHub Actions Inactive


          add more ut

a801766

mainred temporarily deployed to test

April 16, 2024 01:08

— with

GitHub Actions Inactive

AbelHu reviewed

View reviewed changes

parts/windows/windowscsehelper.ps1 Outdated Show resolved Hide resolved

AbelHu reviewed

View reviewed changes

parts/linux/cloud-init/artifacts/cse_helpers.sh Outdated Show resolved Hide resolved

mainred added 2 commits

April 16, 2024 02:46


          fix windows cse exit code error

59c6a25


          Merge branch 'master' of github.com:Azure/AgentBaker into qinhao/cred…

c1e6901

…ential-provider-win-cse

mainred temporarily deployed to test

April 16, 2024 02:47

— with

GitHub Actions Inactive


          remove debug code and ensure flag key

a04290a

mainred temporarily deployed to test

April 16, 2024 03:11

— with

GitHub Actions Inactive

AbelHu approved these changes

View reviewed changes

Member

AbelHu left a comment

LGTM. Thanks for the PR.

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved

staging/cse/windows/configfunc.ps1 Outdated Show resolved Hide resolved

AbelHu requested changes

View reviewed changes

Member

AbelHu left a comment

Please fix the failed ut


          remove unused test

3c1b1ad

mainred temporarily deployed to test

April 16, 2024 03:20

— with

GitHub Actions Inactive

Member Author

mainred commented Apr 16, 2024

Please fix the failed ut

Removed the UT because it's not valid anymore after we check the ensured flag name

Member Author

mainred commented Apr 16, 2024

ping @AbelHu I think this PR is good to continue?


          use global var instead of returing two var in func

159e911

mainred temporarily deployed to test

April 16, 2024 04:06

— with

GitHub Actions Inactive

AbelHu approved these changes

View reviewed changes

Member

AbelHu left a comment

LGTM. Thanks for the PR.

mainred merged commit 04507cf into master

32 checks passed

mainred deleted the qinhao/credential-provider-win-cse branch

April 16, 2024 05:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

andyzhangx andyzhangx left review comments

AbelHu AbelHu approved these changes

juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

ShiqianTao Awaiting requested review from ShiqianTao

junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

Labels

windows cse package