feat: install credential provider support for windows and cache binary in VHD #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainred
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997 and
jason1028kr
as code owners
mainred
force-pushed
the
qinhao/credential-provider-windows
branch
from
9c81ecb to
93a0397
Compare
|
This PR relies on #4281 |
Pull Request Test Coverage Report for Build 8714678746Details
💛 - Coveralls |
mainred
changed the title
mainred
force-pushed
the
qinhao/credential-provider-windows
branch
from
93a0397 to
73548f6
Compare
mainred
force-pushed
the
qinhao/credential-provider-windows
branch
from
73548f6 to
4e6dea7
Compare
mainred
changed the title
…ential-provider-windows
mainred
changed the title
…ential-provider-windows
mainred
commented
Apr 17, 2024
| @@ -410,7 +410,7 @@ start_watch | |||
|
|
|||
| # Kubelet credential provider plugins | |||
| CREDENTIAL_PROVIDER_VERSIONS=" | |||
| 1.29.3 | |||
| 1.29.2 | |||
There was a problem hiding this comment.
windows binary of 1.29.3 is different from global and mooncake for cdn cache issue.
We use 1.29.2 instead, which has the same code as 1.29.3
AbelHu
reviewed
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
install credential provider support for windows and cache binary in VHD
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: